478041 - Site Config vars don't work

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Justin Scott [:fligtar]]

Last night I tried to disable the editor queues and add-on submissions using the admin CP and my changes didn't stick. This usually happened in the past, but I assumed it was because of memcache. I used the flush memcache button and it didn't make a difference, and then I had justdave run the SQL to set the config fields and the had him flush memcache, and the queues/submissions were still enabled.

So there are definitely problems when the config values are disabled, and there may be problems setting the config values. I think a good first step is testing if this works locally and if it might be a memcache issue.

Comment 1

[Wil Clouser [:clouserw]]

This is cake's fault (mostly).  It doesn't escape "key" in one of the queries.  When that query doesn't return the row it tries to do an INSERT which fails on a duplicate key.  I filed a bug for cake at https://trac.cakephp.org/ticket/6089 but since our version is so old we probably should just fix it ourselves.

Comment 2

[Jeff Balogh (:jbalogh)]

Attachment: Fixing the cake escaping problems

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 362327 [details] [diff] [review]
Fixing the cake escaping problems

That's pretty much what I put in the bug but I didn't commit the change because I didn't want to change /cake/.  If you override hasAny() in our code though I'd r+.

Comment 4

[Wil Clouser [:clouserw]]

Comment on attachment 362327 [details] [diff] [review]
Fixing the cake escaping problems

Eh...I changed my mind.  

When we upgrade to cake 1.2 we're not going to be merging changes in, that's going to be a full replacement.  If you want to commit this to /cake/ go for it or you can backport their fix: https://trac.cakephp.org/changeset/8032 .

Thanks.

Comment 5

[Jeff Balogh (:jbalogh)]

r22615