when loading page, some images have white horizontal lines through them

RESOLVED FIXED

Status

Firefox for Android Graveyard
General
RESOLVED FIXED
10 years ago
7 years ago

People

(Reporter: jmaher, Assigned: (dormant account))

Tracking

Details

Attachments

(1 attachment)

if you browse to www.spreadfirefox.com, you will see an image of some fine young mozilla models wearing firefox shirts.  When this loads, you end up with white horizontal lines.

I have seen this on mac and linux desktop versions of fennec from alpha2->current trunk.  Running on the device, I don't see this (maemo only, had trouble loading on my windows mobile build).
I see this effect as well in my Tab Sidebar extension, which uses the MozAfterPaint event to draw the browser contents onto a canvas, much like Fennec, so I suspect the rect sent with the event doesn't cover the whole area of the image drawn as it is loading.
(Assignee)

Comment 2

10 years ago
I see a white border around stuff drawn with drawWindow, This is especially evident on animated images.
I wonder whether this is related to bug 477236? Or perhaps bug 477519...
Sounds more like 477519. A testcase would be great...
I'm not entirely sure it is either, I see the white lines in the canvas when they aren't in the browser display. I'm also not sure how I would construct a testcase that includes a slow loading image since that seems to be what triggers this.
(Assignee)

Comment 6

10 years ago
I think I found the reason for white lines. If i change the color in drawWindow
it becomes obvious.

      ctx.drawWindow(this._browser.contentWindow,
                     rect.left, rect.top,
                     rect.width, rect.height,
                     "red",
                     ctx.DRAWWINDOW_DO_NOT_FLUSH | ctx.DRAWWINDOW_DRAW_CARET);

Now every result of drawWindow is drawn with a red border!!!

also scroll offset fix in bug 477855 seems to fix the bonus problems introduced in fennec.
(Assignee)

Comment 7

10 years ago
Created attachment 363232 [details] [diff] [review]
fixes all of the painting issues i found

this is pretty much the same patch as in bug 477855, except it also deals with animated gif issues(ie mozafterpaint) in addition to viewportHandler fixes. I think this is a more appropriate bug for it.
Attachment #363232 - Flags: review?(pavlov)
(Assignee)

Updated

10 years ago
Blocks: 477855

Updated

10 years ago
Attachment #363232 - Flags: review?(pavlov) → review+
(Assignee)

Comment 8

10 years ago
http://hg.mozilla.org/mobile-browser/rev/f35ab2861209
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

7 years ago
Assignee: nobody → tglek
You need to log in before you can comment on or make changes to this bug.