Closed
Bug 478135
Opened 16 years ago
Closed 6 years ago
"ASSERTION: bits don't correspond to style change reason" with removeAttribute('value')
Categories
(Core :: Layout, defect)
Tracking
()
People
(Reporter: jruderman, Assigned: MatsPalmgren_bugz)
References
(Blocks 1 open bug)
Details
(Keywords: assertion, testcase, Whiteboard: [fixed bug 288704])
Attachments
(1 file)
166 bytes,
text/html
|
Details |
###!!! ASSERTION: bits don't correspond to style change reason: 'aIntrinsicDirty != eStyleChange || aBitToAdd == NS_FRAME_IS_DIRTY', file /Users/jruderman/central/layout/base/nsPresShell.cpp, line 3126
![]() |
||
Comment 1•15 years ago
|
||
nsBlockFrame::AttributeChanged makes exactly the sort of calls this assertion is supposed to catch.
As far as I can see, it shouldn't be using eStyleChange here. In fact, it should probably not be doing anything at all; it would make more sense for the guts of RenumberLists to actually call FrameNeedsReflow on whatever bullets they change. The only issue there is that our setup for marking lines dirty is really slow, so we don't actually want to make such calls....
On the other hand, there's also no point clearing all descendant intrinsic widths here. Or we could just switch to NS_FRAME_IS_DIRTY for the flag; these attributes don't change much.
David, thoughts?
It seem like what this caller is doing is pretty reasonable, although I suppose we could make it use eResize and then do the marking of descendant intrinsics manually just like we set the bits manually.
Updated•11 years ago
|
Assignee: nobody → jdaggett
Updated•9 years ago
|
Assignee: jd.bugzilla → nobody
Updated•7 years ago
|
Blocks: NS_ASSERTION_SUX
Assignee | ||
Comment 4•6 years ago
|
||
This assertion should be fixed now that bug 288704 removed RenumberLists.
However, the list item counter doesn't seem to update correctly now.
I'll fix that in bug 1544590, which includes a WPT for this bug.
Assignee | ||
Updated•6 years ago
|
Flags: in-testsuite+
Updated•6 years ago
|
status-firefox66:
--- → wontfix
status-firefox67:
--- → wontfix
status-firefox68:
--- → fixed
status-firefox-esr60:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•