Closed Bug 478264 Opened 15 years ago Closed 6 years ago

Check for hardcoding numerical values in SQL strings

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: sdwilsh, Unassigned)

References

Details

SQLite ensures that databases can be ported between machines of different endian, but if we hardcode those values, we lose that portability.  We also hit issues when we sometimes hardcode the values into the string, and sometimes use the bind API.

We should enforce that we only ever use the bind* API for numbers.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
Note a dupe - this is about getting an analysis for this so it doesn't happen again.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Status: REOPENED → NEW
and that is about looking for all places where we should bind params... so not sure how you want to differentiate those.
oh this is generic for all Storage users? ok, got it.
Blocks: static_analyses
Product: Core → Firefox Build System
afaik, this didn't happen after, closing.
Status: NEW → RESOLVED
Closed: 15 years ago → 6 years ago
Resolution: --- → WONTFIX
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.