"Received %d of %d headers" should be "Downloaded %d of %d headers."

VERIFIED FIXED in Future

Status

MailNews Core
Networking: NNTP
P3
minor
VERIFIED FIXED
18 years ago
9 years ago

People

(Reporter: Henrik Gemal, Assigned: (not reading, please use seth@sspitzer.org instead))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
http://lxr.mozilla.org/mozilla/source/mailnews/news/src/nsNNTPNewsgroupList.cpp#
921
should be changed to:
"Downloading %d of %d headers."
(Reporter)

Comment 1

18 years ago
Created attachment 12454 [details] [diff] [review]
Diff to fix statustext
(Reporter)

Updated

18 years ago
Keywords: patch
(Reporter)

Comment 2

18 years ago
Created attachment 12457 [details] [diff] [review]
Changed "Downloading" to "Downloaded"

Updated

18 years ago
QA Contact: lchiang → huang

Comment 3

17 years ago
future per mail triage (to get this off our radar) for ns release

Since there is a patch, please go through the Mozilla review/approval process.  
sspitzer is on sabbatical.  Should be back next week.
Target Milestone: --- → Future
(Reporter)

Comment 4

17 years ago
Fixing up subjetc to match diff
Summary: "Received %d of %d headers" should be "Downloading %d of %d headers." → "Received %d of %d headers" should be "Downloaded %d of %d headers."
Is there a UE spec here? I'm pretty ignorant of such things, and a techie anyway
(who uses jargon), but why is "Downloaded" better than "Received"?

/be

Comment 6

17 years ago
I don't think there is a spec.  I'll just cc: jglick for her UE feedback.

Comment 7

17 years ago
There is no UE spec on this. Cc'ing Robin Foster from Tech Pubs to see if she 
has a preference.  

Either "Downloaded" or "Received" works for me.

Comment 8

17 years ago
I prefer "downloaded", since it's consistent with the "download" terminology 
that we use elsewhere (folder properties, for example, has "download" options).
(Reporter)

Comment 9

17 years ago
If we agree on "Downloaded" could someone please check this one in...?
Keywords: review

Comment 10

17 years ago
Ccing putterman, can you help Henrik for check this one in...?
(Reporter)

Comment 11

17 years ago
Trying out my checkin guru...

Comment 12

17 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 13

17 years ago
You're my (patch)man!

Comment 14

17 years ago
Sorry to ask this question now, but I was out sick the last few days.  Did you 
only change news? I don't know what the rest of mailnews says, but it would seem 
wrong to only have news say Downloaded and to have Pop and Imap say Received.  I 
did a quick search and it looks like every place is saying "Received". So we 
basically created an inconsistency by checking this in when there really wasn't 
that big of a problem in the first place.  Also, this isn't your fault since you 
just changed the code that was there, but this string is clearly not 
localizable.

The other thing is that Brendan gave approval for Mozilla, but who gave approval 
from the mailnews module?  I see that r=gemal in the checkin which isn't a 
legitimate review given that he wrote the code!  I've seen this happen a few 
times in the past and haven't brought it up, but you really need to get approval 
from one of the mailnews module owners before checking in and you also need to 
get a review from the person whose code you are making changes to.  I recognize 
that this was hard given that Seth was out and that I was sick and nobody 
probably noticed your patch, but it still needs to be done.
(Reporter)

Comment 15

17 years ago
I think the wrong diff patch went in...

It now says "Downloading %d of %d headers." when it should be (like in patch 2) 
"Downloaded %d of %d headers."
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
accepting this bug.  I'll start with gemal's patch, but it needs to be made
localizable.

this is very similar to bug #47830.

gemal, see my fix for that if you are interested in fixing this bug.
Status: REOPENED → ASSIGNED
Mass moving all NEWS bugs from esther to myself.
QA Contact: huang → stephend
I've finally done the work to fix this and make it i18n friendly.

I'll post the patch in a few minutes for review.
fixed.

Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED
note I checked in a slightly different patch.  bienvenu reviewed it before I
checked it in.
Okay, it now says, "Downloading 2400 of 2400 headers". Mac 2000122105, Linux
122108 and Win2K, 2000122105. VERIFIED FIXED.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.