47833 - crash in preferences dialog [jp?]

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P1)

Description

[Koike Kazuhiko]

Mozilla crashes in preference dialog.

Case 1: 

200080505(Linux)
Debian GNU/Linux Woody(Kernel 2.2.17 Pre6)

(1) Open [Edit]-[Preferences].
(2) Click "Pages in history expire after" textfield in "History" tab.

Case 2:

200080505(Linux)
Debian GNU/Linux Woody(Kernel 2.2.17 Pre6)

(1) Open [Edit]-[Preferences].
(2) Select "Language encoding" combobox in "Fonts" tab.


This bug was originally reported on Japanized bugzilla.
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=167

Comment 1

[Jeffrey Baker]

Can't reproduce on Linux 2000080605 (M17).

Comment 2

[Koike Kazuhiko]

Crash happens if LANG=ja_JP.ujis or LANG=ja_JP.eucJP.

Comment 3

[sairuh (rarely reading bugmail)]

teruko, can you confirm this?

Comment 4

[Teruko Kobayashi]

I cannot reproduce in 2000-08-07-04 M17 build with Linux Redhat 6.2 JA.
I tested the different locale, LANG=ja_JP, LANG=ja_JP.ujis and LANG=ja_JP.eucJP,
but Netscape did not crash.

The problem may happen in the different Linux machine.

cc'd [e-mail],[e-mail],[e-mail].

Tajima-san or Katakai-san,
Can you reproduce this problem in linux machine other than Redhat?

Comment 5

[INOUE Seiichiro]

I can reproduce this problem with various builds, and I found it depends on XIM.
I tried both kinput2 and VJE-Delta, and I got a slightly different results.
In case of kinput2, Mozilla crashes. 
In case of VJE-Delta, it freezes.
In addition, the timing is also different (you need to click on some widgets on 
the dialog box).
I have a stack trace of the crash case(connected to kinput2).
While I debug it, XSetICValues() is called correctly.

------------
#0  0x4039a657 in memcpy () from /lib/libc.so.6
#1  0x40c94fa5 in _XimWrite () from /usr/X11R6/lib/libX11.so.6
#2  0x40c9514e in _XimRead () from /usr/X11R6/lib/libX11.so.6
#3  0x40c82de9 in _XimUnregisterServerFilter () from /usr/X11R6/lib/libX11.so.6
#4  0x40c64e13 in XSetICValues () from /usr/X11R6/lib/libX11.so.6
#5  0x40bc9d4d in gdk_ic_real_set_attr (ic=0x88e0c9c, attr=0x88e0cb4,
mask=GDK_IC_FOCUS_WINDOW)
    at gdkim.c:759
#6  0x40bca72b in gdk_ic_set_attr (ic=0x88e0c9c, attr=0xbfffe8e8,
mask=GDK_IC_FOCUS_WINDOW)
    at gdkim.c:1206
#7  0x40bc8f07 in gdk_im_begin (ic=0x88e0c9c, window=0x88885a4) at gdkim.c:182
#8  0x40a2c6c0 in nsIMEGtkIC::SetFocusWidget (this=0x88e0be8,
aFocusWidget=0x88883a0)
    at nsGtkIMEHelper.cpp:957
#9  0x40a21872 in nsWidget::IMESetFocusWidget (this=0x88883a0) at
nsWidget.cpp:3357
#10 0x40a257ab in nsWindow::SetFocus (this=0x88883a0) at nsWindow.cpp:1061
------------

My environment:
Debian GNU/Linux 2.2 (potato)
XFree86 3.3.6

Comment 6

[Masaki Katakai]

Problems seem to happen on Debian and Kondara distribution.
I'll get them and try to reproduce.

Comment 7

[Masaki Katakai]

I prepared Kondara distribution here and I verified
this problem happens on it. I'll look into the problem.
It seems that XIM codes cause the problem. Can anyone
change Assigned engineer to [e-mail]?

Comment 8

[Teruko Kobayashi]

Reassign this to [e-mail].

Comment 9

[leger]

Adding crash keyword.

Comment 10

[Masaki Katakai]

In nsWidget::IMESetFocusWidget(), when nsIMEGtkIC::UnsetFocusWidget() is called
once,
Mozilla will crash. However, I'm not sure why it happens on only Kondara
distribution.
I think we don't have to call nsIMEGtkIC::UnsetFocusWidget() (gdk_im_end()) at
that point now, so we can remove the codes to fix this problem, which should not
cause any serious problem to other distributions. I'll check.

Comment 11

[sairuh (rarely reading bugmail)]

confirming since some people can repro this.

Comment 12

[Frank Tang]

add pavlov to the cc list.

Comment 13

[Jaime Rodriguez, Jr.]

Marking nsbeta3+ per I18N bug triage.

Comment 14

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Adding topcrash keyword since this is probably in the top 10 linux crashers on 
talkback (certainly 20), if one also includes crashes within 
nsIMEGtkIC::~nsIMEGtkIC.  Are those crashes part of this bug or should they be 
filed separately?  Talkback reports in the past week are the following, although 
I've seen more in previous weeks (these reports have been around for a while):

SetFocusWidget:
http://cyclone/reports/incidenttemplate.cfm?bbid=16168411

~nsIMEGtkIC:
http://cyclone/reports/incidenttemplate.cfm?bbid=16168346
http://cyclone/reports/incidenttemplate.cfm?bbid=16166134

Comment 15

[Masaki Katakai]

Hi David, Thanks. (I could not access to http://cyclone/reports/...,
could you tell me how to access the page?)

Yes, could you file a seperate bug for ~nsIMEGtkIC case?
We'll investigate it.

I have a fix for SetFocusWidget case in my local tree,
which will be integrated with other IME fixes.

Comment 16

[Hidetoshi Tajima]

We cannot get to access any URL of http://cyclon/, please send URLs externally
accessible.

Comment 17

[Frank Tang]

Here is the crash stack trace of 
http://cyclone/reports/incidenttemplate.cfm?bbid=16168411


 Trigger Type:  Program Crash 

 Trigger Reason:  SIGSEGV: Segmentation Fault: (signal 11) 

 Call Stack:    (Signature = libc.so.6 + 0x58788 (0x4029d788) 70c98ff0) 
     
   libc.so.6 + 0x58788 (0x4029d788) 
                                                    
     
   libX11.so.6 + 0x7d5ef (0x407df5ef) 
                                                    
     
   libX11.so.6 + 0x6a809 (0x407cc809) 
                                                    
     
   libX11.so.6 + 0x4a559 (0x407ac559) 
                                                    
     
   libgdk-1.2.so.0 + 0x1b429 (0x40713429) 
                                                    
     
   libgdk-1.2.so.0 + 0x1be3c (0x40713e3c) 
                                                    
     
   libgdk-1.2.so.0 + 0x1c5f9 (0x407145f9) 
                                                    
     
   nsIMEGtkIC::SetFocusWidget() 
                                                    
     
   nsWidget::IMESetFocusWidget() 
                                                    
     
   nsWindow::SetFocus() 
                                                    
     
   GlobalWindowImpl::Focus() 
                                                    
     
   nsWebShellWindow::HandleEvent() 
                                                    
     
   nsWidget::DispatchEvent() 
                                                    
     
   nsWidget::DispatchWindowEvent() 
                                                    
     
   nsWidget::DispatchFocus() 
                                                    
     
   nsWindow::DispatchSetFocusEvent() 
                                                    
     
   handle_toplevel_focus_in() 
                                                    
     
   libgtk-1.2.so.0 + 0x9c35f (0x4065735f) 
                                                    
     
   libgtk-1.2.so.0 + 0xcf581 (0x4068a581) 
                                                    
     
   libgtk-1.2.so.0 + 0xceadb (0x40689adb) 
                                                    
     
   libgtk-1.2.so.0 + 0xcd17b (0x4068817b) 
                                                    
     
   libgtk-1.2.so.0 + 0x108ef0 (0x406c3ef0) 
                                                    
     
   libgtk-1.2.so.0 + 0x9b19e (0x4065619e) 
                                                    
     
   handle_gdk_event() 
                                                    
     
   libgdk-1.2.so.0 + 0x17360 (0x4070f360) 
                                                    
     
   libglib-1.2.so.0 + 0x10bfa (0x4073fbfa) 
                                                    
     
   libglib-1.2.so.0 + 0x11227 (0x40740227) 
                                                    
     
   libglib-1.2.so.0 + 0x11cd2 (0x40740cd2) 
                                                    
     
   nsAppShell::DispatchNativeEvent() 
                                                    
     
   nsXULWindow::ShowModal() 
                                                    
     
   nsWebShellWindow::ShowModal() 
                                                    
     
   nsChromeTreeOwner::ShowModal() 
                                                    
     
   GlobalWindowImpl::OpenInternal() 
                                                    
     
   GlobalWindowImpl::OpenDialog() 
                                                    
     
   WindowOpenDialog() 
                                                    
     
   js_Invoke() 
                                                    
     
   js_Interpret() 
                                                    
     
   js_Invoke() 
                                                    
     
   js_InternalInvoke() 
                                                    
     
   JS_CallFunctionValue() 
                                                    
     
   nsJSContext::CallEventHandler() 
                                                    
     
   nsJSEventListener::HandleEvent() 
                                                    
     
   nsEventListenerManager::HandleEventSubType() 
                                                    
     
   nsEventListenerManager::HandleEvent() 
                                                    
     
   nsXULElement::HandleDOMEvent() 
                                                    
     
   PresShell::HandleDOMEventWithTarget() 
                                                    
     
   nsButtonBoxFrame::MouseClicked() 
                                                    
     
   nsButtonBoxFrame::HandleEvent() 
                                                    
     
   PresShell::HandleEventInternal() 
                                                    
     
   PresShell::HandleEventWithTarget() 
                                                    
     
   nsEventStateManager::CheckForAndDispatchClick() 
                                                    
     
   nsEventStateManager::PostHandleEvent() 
                                                    
     
   PresShell::HandleEventInternal() 
                                                    
     
   PresShell::HandleEvent() 
                                                    
     
   nsView::HandleEvent() 
                                                    
     
   nsViewManager2::DispatchEvent() 
                                                    
     
   HandleEvent() 
                                                    
     
   nsWidget::DispatchEvent() 
                                                    
     
   nsWidget::DispatchWindowEvent() 
                                                    
     
   nsWidget::DispatchMouseEvent() 
                                                    
     
   nsWidget::OnButtonReleaseSignal() 
                                                    
     
   nsWindow::HandleGDKEvent() 
                                                    
     
   dispatch_superwin_event() 
                                                    
     
   handle_gdk_event() 
                                                    
     
   libgdk-1.2.so.0 + 0x17360 (0x4070f360) 
                                                    
     
   libglib-1.2.so.0 + 0x10bfa (0x4073fbfa) 
                                                    
     
   libglib-1.2.so.0 + 0x11227 (0x40740227) 
                                                    
     
   libglib-1.2.so.0 + 0x11b54 (0x40740b54) 
                                                    
     
   libgtk-1.2.so.0 + 0x9ab6d (0x40655b6d) 
                                                    
     
   nsAppShell::Run() 
                                                    
     
   nsAppShellService::Run() 
                                                    
     
   main1() 
                                                    
     
   main() 
                                                    
     
   libc.so.6 + 0x18c5e (0x4025dc5e) 
                                                    

Comment 18

[Frank Tang]

Here is the stack trace for 
http://cyclone/reports/incidenttemplate.cfm?bbid=16168346

 Machine State 

 OVERVIEW   |   ENVIRONMENT   |   CODE AROUND THE PC   |   SHARED OBJECTS 

 Trigger Type:  Program Crash 

 Trigger Reason:  SIGSEGV: Segmentation Fault: (signal 11) 

 Call Stack:    (Signature = libc.so.6 + 0x58779 (0x4029d779) 391b1a65) 
     
   libc.so.6 + 0x58779 (0x4029d779) 
                                                    
     
   libX11.so.6 + 0x7d5ef (0x407df5ef) 
                                                    
     
   libX11.so.6 + 0x6ab86 (0x407ccb86) 
                                                    
     
   libX11.so.6 + 0x4a445 (0x407ac445) 
                                                    
     
   libgdk-1.2.so.0 + 0x1b2d7 (0x407132d7) 
                                                    
     
   nsIMEGtkIC::~nsIMEGtkIC() 
                                                    
     
   nsWidget::IMEDestroyIC() 
                                                    
     
   nsWindow::DestroyNative() 
                                                    
     
   nsWidget::Destroy() 
                                                    
     
   nsWindow::Destroy() 
                                                    
     
   nsWindow::~nsWindow() 
                                                    
     
   nsBaseWidget::Release() 
                                                    
     
   nsWidget::Release() 
                                                    
     
   nsWindow::Release() 
                                                    
     
   nsCOMPtr_base::assign_with_AddRef() 
                                                    
     
   nsXULWindow::Destroy() 
                                                    
     
   nsWebShellWindow::Destroy() 
                                                    
     
   nsChromeTreeOwner::Destroy() 
                                                    
     
   GlobalWindowImpl::Close() 
                                                    
     
   GlobalWindowImpl::CloseWindow() 
                                                    
     
   nsJSContext::ScriptEvaluated() 
                                                    
     
   nsJSContext::CallEventHandler() 
                                                    
     
   nsJSEventListener::HandleEvent() 
                                                    
     
   nsEventListenerManager::HandleEventSubType() 
                                                    
     
   nsEventListenerManager::HandleEvent() 
                                                    
     
   nsXULElement::HandleDOMEvent() 
                                                    
     
   PresShell::HandleEventInternal() 
                                                    
     
   PresShell::HandleEventWithTarget() 
                                                    
     
   nsEventStateManager::CheckForAndDispatchClick() 
                                                    
     
   nsEventStateManager::PostHandleEvent() 
                                                    
     
   PresShell::HandleEventInternal() 
                                                    
     
   PresShell::HandleEvent() 
                                                    
     
   nsView::HandleEvent() 
                                                    
     
   nsViewManager2::DispatchEvent() 
                                                    
     
   HandleEvent() 
                                                    
     
   nsWidget::DispatchEvent() 
                                                    
     
   nsWidget::DispatchWindowEvent() 
                                                    
     
   nsWidget::DispatchMouseEvent() 
                                                    
     
   nsWidget::OnButtonReleaseSignal() 
                                                    
     
   nsWindow::HandleGDKEvent() 
                                                    
     
   dispatch_superwin_event() 
                                                    
     
   handle_gdk_event() 
                                                    
     
   libgdk-1.2.so.0 + 0x17360 (0x4070f360) 
                                                    
     
   libglib-1.2.so.0 + 0x10bfa (0x4073fbfa) 
                                                    
     
   libglib-1.2.so.0 + 0x11227 (0x40740227) 
                                                    
     
   libglib-1.2.so.0 + 0x11b54 (0x40740b54) 
                                                    
     
   libgtk-1.2.so.0 + 0x9ab6d (0x40655b6d) 
                                                    
     
   nsAppShell::Run() 
                                                    
     
   nsAppShellService::Run() 
                                                    
     
   main1() 
                                                    
     
   main() 
                                                    
     
   libc.so.6 + 0x18c5e (0x4025dc5e) 
                                                    


 Registers: 
 EAX:
      006e6962
                     EBX:
                          4082d6d8
                                         ECX:
                                              080d1fc0
                                                             EDX:
                                                                  00000000
 ESI:
      bffffff8
                     EDI:
                          418605e8
                                         ESP:
                                              bfffd934
                                                             EBP:
                                                                  bfffd978
 EIP:
      4029d779
                     cf PF af zf sf of IF df nt RF vm   IOPL: 0 

 CS:
     0023
             DS:
                002b
                        SS:
                            002b
                                    ES:
                                       002b
                                               FS:
                                                   0000
                                                           GS:
                                                              0000


 Stack Dump:

Comment 19

[Frank Tang]

Here is the stack trace for 
http://cyclone/reports/incidenttemplate.cfm?bbid=16166134

Trigger Type:  Program Crash 

 Trigger Reason:  SIGSEGV: Segmentation Fault: (signal 11) 

 Call Stack:    (Signature = libc.so.6 + 0x58779 (0x4029d779) 391b1a65) 
     
   libc.so.6 + 0x58779 (0x4029d779) 
                                                    
     
   libX11.so.6 + 0x7d5ef (0x407df5ef) 
                                                    
     
   libX11.so.6 + 0x6ab86 (0x407ccb86) 
                                                    
     
   libX11.so.6 + 0x4a445 (0x407ac445) 
                                                    
     
   libgdk-1.2.so.0 + 0x1b2d7 (0x407132d7) 
                                                    
     
   nsIMEGtkIC::~nsIMEGtkIC() 
                                                    
     
   nsWidget::IMEDestroyIC() 
                                                    
     
   nsWindow::DestroyNative() 
                                                    
     
   nsWidget::Destroy() 
                                                    
     
   nsWindow::Destroy() 
                                                    
     
   nsWindow::~nsWindow() 
                                                    
     
   nsBaseWidget::Release() 
                                                    
     
   nsWidget::Release() 
                                                    
     
   nsWindow::Release() 
                                                    
     
   nsCOMPtr_base::assign_with_AddRef() 
                                                    
     
   nsXULWindow::Destroy() 
                                                    
     
   nsWebShellWindow::Destroy() 
                                                    
     
   nsChromeTreeOwner::Destroy() 
                                                    
     
   GlobalWindowImpl::Close() 
                                                    
     
   GlobalWindowImpl::CloseWindow() 
                                                    
     
   nsJSContext::ScriptEvaluated() 
                                                    
     
   nsJSContext::CallEventHandler() 
                                                    
     
   nsJSEventListener::HandleEvent() 
                                                    
     
   nsEventListenerManager::HandleEventSubType() 
                                                    
     
   nsEventListenerManager::HandleEvent() 
                                                    
     
   nsXULElement::HandleDOMEvent() 
                                                    
     
   PresShell::HandleEventInternal() 
                                                    
     
   PresShell::HandleEventWithTarget() 
                                                    
     
   nsEventStateManager::CheckForAndDispatchClick() 
                                                    
     
   nsEventStateManager::PostHandleEvent() 
                                                    
     
   PresShell::HandleEventInternal() 
                                                    
     
   PresShell::HandleEvent() 
                                                    
     
   nsView::HandleEvent() 
                                                    
     
   nsViewManager2::DispatchEvent() 
                                                    
     
   HandleEvent() 
                                                    
     
   nsWidget::DispatchEvent() 
                                                    
     
   nsWidget::DispatchWindowEvent() 
                                                    
     
   nsWidget::DispatchMouseEvent() 
                                                    
     
   nsWidget::OnButtonReleaseSignal() 
                                                    
     
   nsWindow::HandleGDKEvent() 
                                                    
     
   dispatch_superwin_event() 
                                                    
     
   handle_gdk_event() 
                                                    
     
   libgdk-1.2.so.0 + 0x17360 (0x4070f360) 
                                                    
     
   libglib-1.2.so.0 + 0x10bfa (0x4073fbfa) 
                                                    
     
   libglib-1.2.so.0 + 0x11227 (0x40740227) 
                                                    
     
   libglib-1.2.so.0 + 0x11b54 (0x40740b54) 
                                                    
     
   libgtk-1.2.so.0 + 0x9ab6d (0x40655b6d) 
                                                    
     
   nsAppShell::Run() 
                                                    
     
   nsAppShellService::Run() 
                                                    
     
   main1() 
                                                    
     
   main() 
                                                    
     
   libc.so.6 + 0x18c5e (0x4025dc5e) 
                                                    


 Registers: 
 EAX:
      006e6962
                     EBX:
                          4082d6d8
                                         ECX:
                                              080d2180
                                                             EDX:
                                                                  00000000
 ESI:
      bffffff8
                     EDI:
                          4157a628
                                         ESP:
                                              bfffd8f4
                                                             EBP:
                                                                  bfffd938
 EIP:
      4029d779
                     cf pf af zf sf of IF df nt RF vm   IOPL: 0 

 CS:
     0023
             DS:
                002b
                        SS:
                            002b
                                    ES:
                                       002b
                                               FS:
                                                   0000
                                                           GS:
                                                              0000

Comment 20

[Frank Tang]

crash, mark it as P1.

Comment 21

[Frank Tang]

tajima said they have the fix in hand. They are currently do more testing before 
sending out for code review. 

Comment 22

[Hidetoshi Tajima]

Attachment: changes for focus window management for XIC in accord to editor side changes

Comment 23

[Hidetoshi Tajima]

A patch is posted. This is a combined patch for this problem and 47568, and is
under code review
for check-in approval. marked WORKSFORME.

Comment 24

[Hidetoshi Tajima]

forgot to mark.

Comment 25

[Frank Tang]

reopen
tajima- you should mark "FIXED" when you check in the code.
WORKFORME mean it work for  you WITHOUT any changes.

Comment 26

[Stuart Parmenter]

r=pavlov

Comment 27

[Hidetoshi Tajima]

checked in the code(r=pavlov,a=waterson). 

Comment 28

[Frank Tang]

mark it fixed

Comment 29

[Teruko Kobayashi]

KOIKE san, could you verify this?  I cannot verify this because I could not get 
crash at the beginning.
                                                                                             

Comment 30

[Koike Kazuhiko]

A Debian user said the problem seemed to be resolved in
Linux build 2000090821.

http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=167