478500 - Make editor not lose focus when you click a toolbar button (or think it loses focus)

Status: RESOLVED INVALID

(Skywriter Graveyard :: General, defect, P2)

Description

[Ben Galbraith]

From Jesse

Comment 1

[Gordon P. Hemsley [:GPHemsley]]

This is a mass migration from Mozilla Labs :: Bespin to Bespin :: General.

This bug likely still needs to be triaged and categorized.

Comment 2

[Ben Galbraith]

Pretty silly that we haven't fixed this yet

Comment 3

[Ryan Moore]

The editor triggers onblur actions when something else is clicked, it seems to make the most sense to add explicit re-focus events JUST for the toolbar buttons. This patch should fix save / preview / fontsize, does the same fix need to be applied anywhere else?

diff -r 1dfcd89b80f0 frontend/js/bespin/editor/toolbar.js
--- a/frontend/js/bespin/editor/toolbar.js      Thu Aug 20 16:25:16 2009 +0100
+++ b/frontend/js/bespin/editor/toolbar.js      Fri Aug 21 08:43:15 2009 -0700
@@ -143,6 +143,7 @@
 
             dojo.connect(save, 'click', function() {
                 bespin.get("editor").saveFile();
+                bespin.get("editor").setFocus(true);
             });
         },
 
@@ -206,6 +207,7 @@
             dojo.connect(preview, 'click', function() {
                 // Defaults to current
                 bespin.preview.show();
+                bespin.get("editor").setFocus(true);
             });
         },
 
@@ -232,8 +234,9 @@
                 dojo.connect(fontsize, 'click', function() {
                     currentFontSize = (currentFontSize > 2) ? 1 : currentFontSize + 1;
                     bespin.publish("settings:set:fontsize", [{ value: fontSizes[currentFontSize] }]);
+                    bespin.get("editor").setFocus(true);
                 });
             })();
         }
     }
-});
\ No newline at end of file
+});

Comment 4

[Ben Galbraith]

setting to P2 and targetting 0.4.3 (because ryan went to trouble to patch, we should process if we can)

Comment 5

[Kevin Dangoor]

ACETRANSITION

The Skywriter project has merged with Ajax.org's Ace project (the full server part of which is their Cloud9 IDE project). Background on the change is here:

http://mozillalabs.com/skywriter/2011/01/18/mozilla-skywriter-has-been-merged-into-ace/

The bugs in the Skywriter product are not necessarily relevant for Ace and quite a bit of code has changed. For that reason, I'm closing all of these bugs. Problems that you have with Ace should be filed in the Ace issue tracker at GitHub:

https://github.com/ajaxorg/ace/issues