47853 - Second send operation fails due to missing HELO

Status: VERIFIED FIXED

(MailNews Core :: Networking: SMTP, defect, P3)

Description

[Ben Bucksch (:BenB)]

I can usually send exactly one mail per session. Each following attempt fails
with an error: "[...] The mail server responded: MAIL FROM must be preceded by
HELO/EHLO command. Please verify that your email address is correct in your Mail
preferences and try again.". 100% reproducable for me.

Comment 1

[Scott MacGregor]

I think this is a dup of some other HELO/EHLO bugs I have. I think Jeff's whacky 
smtp capabilities caching code really broke a lot of stuff like this. I'm 
tempted to just turn it off since he's out on sabbatical and it really doesn't 
work very well. 

Another possibility is that someone in compose isn't forcing us to create a new 
smtp protocol instance. 

Comment 2

[Scott MacGregor]

Ben, I'm working on a patch that backs out all the smtp capability caching. But
I don't have a server to test against that requires that HELO/EHLO gets sent
first. If I post a patch can you test it against your mail server?

Comment 3

[Scott MacGregor]

Attachment: proposed fix

Comment 4

[Scott MacGregor]

This patch fixes this problem for me. I see the EHLO going out every time we
send now. 

Comment 5

[Scott MacGregor]

Fix checked in. 

Comment 6

[Ben Bucksch (:BenB)]

Verified with custom build on Linux.

Comment 7

[Ben Bucksch (:BenB)]

tnx