Closed
Bug 478586
Opened 16 years ago
Closed 16 years ago
Patch submission: Turn the login form into a real form
Categories
(Skywriter Graveyard :: General, defect, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
0.2.x
People
(Reporter: frew, Unassigned)
Details
Attachments
(3 files, 1 obsolete file)
1.64 KB,
patch
|
Details | Diff | Splinter Review | |
1.45 KB,
patch
|
Details | Diff | Splinter Review | |
759 bytes,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9.0.6) Gecko/2009011912 Firefox/3.0.6
Build Identifier: hg trunk
Currently, the login form is not an actual form. This means that Firefox password saving and default form keybindings don't work. The submitted patch changes this while preserving aesthetics. I'm not a huge frontend hacker, so let me know what horrible travesties I've committed.
Reproducible: Always
Reporter | ||
Comment 1•16 years ago
|
||
Reporter | ||
Updated•16 years ago
|
Attachment #362433 -
Flags: review?(dion)
Reporter | ||
Comment 2•16 years ago
|
||
Comment on attachment 362433 [details] [diff] [review]
Patch turning login_form into an actual form
almaer,
It looks like you've been doing a lot of auth related checkins. Mind reviewing this patch? It's really small and probably somewhat wrong, but I'd like to go through the process once before moving on to bigger stuff.
Thanks
-Fred
Comment 3•16 years ago
|
||
Fred,
Firstly, I wanted to say thanks so much for taking the time to get engaged in the project. Very much appreciated!
You took on something that we need to change here, and your patch gets close.
We want to make this a real form as we want to be able to type in the user and password and then hit enter.
However, instead of just: <form action=""> we should have an onSubmit on the form to actually do the work. Then we get there, and hitting enter will do the trick.
Want to get that in there?
Cheers,
Dion
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P4
Target Milestone: -- → 0.2
Reporter | ||
Comment 4•16 years ago
|
||
Updated in response to review. Please take another look. Thanks! :)
Attachment #362433 -
Attachment is obsolete: true
Attachment #362433 -
Flags: review?(dion)
Reporter | ||
Updated•16 years ago
|
Attachment #362433 -
Flags: review?(dion)
Reporter | ||
Updated•16 years ago
|
Attachment #362528 -
Flags: review?(dion)
Comment 5•16 years ago
|
||
Looking good Fred. One issue: The login button is now an image that doesn't do anything. Ideally, it would be a type="submit" with a CSS background, or a type="image". What do you think?
Reporter | ||
Comment 6•16 years ago
|
||
Possibly I'm missing another button, but I think I turned the login button into an input with type="image"?
Comment 7•16 years ago
|
||
I continued Fred's work and made two patches myself. In addition to the form they also add label elements and move inline styles to index.css. Unfortunately I have no experience in creating patches and I don't use Mercurial. I hope the patches are useful all the same. If you want to create the patches yourself I can attach the edited files.
Attachment #363491 -
Flags: review?(dion)
Comment 9•16 years ago
|
||
Thanks to you both for this. Very much appreciated.
Changeset: 292d93668921
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Version: unspecified → Trunk
Comment 10•16 years ago
|
||
This is a mass migration from Mozilla Labs :: Bespin to Bespin :: General.
This bug likely still needs to be triaged and categorized.
Component: Bespin → General
Product: Mozilla Labs → Bespin
QA Contact: bespin → general
Target Milestone: 0.2 → 0.2.x
Updated•13 years ago
|
Attachment #362528 -
Flags: review?(dion)
Updated•13 years ago
|
Attachment #363491 -
Flags: review?(dion)
Comment 11•13 years ago
|
||
Comment on attachment 363492 [details] [diff] [review]
improved form patch, css
Clearing review flags, per comment 9 this has already landed.
If this is not the case or there are remaining issues, please file a new bug with patch and mark it as blocking this bug.
Attachment #363492 -
Flags: review?
You need to log in
before you can comment on or make changes to this bug.
Description
•