Closed Bug 478625 Opened 12 years ago Closed 12 years ago

Visual fixes for new-tab button on linux

Categories

(Firefox :: Theme, defect, P2)

Product:
Firefox
Component:
Theme
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.6a1

People

(Reporter: micmon, Assigned: ventnor.bugzilla)

Details

(Keywords: polish, verified1.9.1, Whiteboard: [polish-easy] [polish-visual] [icon-shiretoko][polish-p1])

Attachments

(2 files, 1 obsolete file)

Screenshot of the un-fixed button in current builds
4.28 KB, image/png
Details
Patch 2
1.96 KB, patch
Details | Diff | Splinter Review 
The new-tab button (the one that is part of the tab bar)
a) has a strange form factor
b) touches the bottom edge, which looks bad on hover/press

As a workaround, this seems to work:

.tabs-newtab-button {
  margin:        2px !important;
  margin-left:   1px !important;
  height:       24px !important;
  width:        24px !important;
}
Component: Tabbed Browser → Theme
OS: Linux → All
QA Contact: tabbed.browser → theme
Hardware: x86 → All
OS: All → Linux
Hardware: All → x86
Keywords: polish
Whiteboard: [polish-easy] [polish-visual]
Attached patch Patch (obsolete) — — Splinter Review 
I primarily changed the icon to be consistent with the other platforms (a + icon), but also decided to fix the bottom border after finding this bug. This should go into 1.9.1 to help finish off the theme changes planned for it, on the Linux side.
Assignee: nobody → ventnor.bugzilla
Status: NEW → ASSIGNED
Attachment #362900 - Flags: review?(rflint)
Comment on attachment 362900 [details] [diff] [review]
Patch

please remove newtab.png from jar.mn and the repository
Attachment #362900 - Flags: review?(rflint) → review+
Attached patch Patch 2 — — Splinter Review
Attachment #362900 - Attachment is obsolete: true
(Although its nothing to do with this bug; Dao, if you're planning to check this in, could you also do bug 473882 at the same time to fix another theme issue)
Keywords: checkin-needed
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual] [needs landing]
http://hg.mozilla.org/mozilla-central/rev/56054d50c13c

I noticed that the vertical alignment of the icon was off with the patch and fixed this before landing it.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [polish-easy] [polish-visual] [needs landing] → [polish-easy] [polish-visual]
Target Milestone: --- → Firefox 3.2a1
Attachment #362905 - Flags: approval1.9.1?
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual] [icon-3.1]
Flags: blocking-firefox3.1?
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Priority: -- → P2
Keywords: checkin-needed
Attachment #362905 - Flags: approval1.9.1?
Verified using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3
Status: RESOLVED → VERIFIED
verified FIXED on Shiretoko:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b5pre) Gecko/20090513 Shiretoko/3.5b5pre ID:20090513030639
Keywords: fixed1.9.1 → verified1.9.1
This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.
Whiteboard: [polish-easy] [polish-visual] [icon-3.1] → [polish-easy] [polish-visual] [icon-shiretoko][polish-p1]
You need to log in before you can comment on or make changes to this bug.