478939 - listboxes should support three finger swipe up/down on Mac OS X

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Ed Lee :Mardak]

Swipe up/down to jump to the top and bottom of the list. Used in places like uh.. View -> Character Encoding -> Customize List...

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Neil Deakin]

Comment on attachment 362766 [details] [diff] [review]
v1

OK, although an error will occur when the list is empty due to bug 420424.

Comment 3

[Ed Lee :Mardak]

http://hg.mozilla.org/mozilla-central/rev/576fd7248118

Comment 4

[Steffen Wilberg]

So what's the reason for the code duplication in richlistbox.xml and listbox.xml?
richlistbox extends the listbox-base binding, but this handler is in the listbox binding, and richlistbox got its own handler in bug 478607.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I think we should better handle this in bug 478607. Perhaps reopening bug 478607 due to follow-up fix?

Comment 6

[Ed Lee :Mardak]

Part of the reason for a separate richlistbox implementation was that richlistitems can contain anything of varying size and styles -- potentially display: none;

But sure, perhaps it would be better to have it shared.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's awesome! Verified fixed on 1.9.1 branch with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090221 Minefield/3.2a1pre Ubiquity/0.1.5 ID:20090221020633

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Edward, is this patch ready for 1.9.1?

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 362766 [details] [diff] [review]
v1

Mardak: can you get a test together and renominate? Gavin can show you how if you need help.