variable ix used before declaration in SM sessionstore

RESOLVED FIXED in seamonkey2.0b1

Status

SeaMonkey
Session Restore
--
minor
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: Misak Khachatryan, Assigned: Misak Khachatryan)

Tracking

Trunk
seamonkey2.0b1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 362894 [details] [diff] [review]
declare ix before use
[Checkin: Comment 3]

Variable ix in sss_observe function was not declared before using, which is a bad practice. one liner patch is attached.
Attachment #362894 - Flags: superreview?(neil)
Attachment #362894 - Flags: review?(neil)
Attachment #362894 - Flags: approval-seamonkey2.0a3?

Updated

9 years ago
Attachment #362894 - Flags: superreview?(neil)
Attachment #362894 - Flags: superreview+
Attachment #362894 - Flags: review?(neil)
Attachment #362894 - Flags: review+

Comment 1

9 years ago
Comment on attachment 362894 [details] [diff] [review]
declare ix before use
[Checkin: Comment 3]

This is nice to have but the tree is really closed for a3 now, we only take things there that actually have noticeable reward, and this doesn't.

Please land as soon as the tree reopens after the release branch has been cut.
Attachment #362894 - Flags: approval-seamonkey2.0a3? → approval-seamonkey2.0a3-
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
(This "ports" bug 479005.)
Assignee: nobody → misak
Status: NEW → ASSIGNED
Depends on: 479005
Target Milestone: --- → seamonkey2.0b1
Comment on attachment 362894 [details] [diff] [review]
declare ix before use
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/a97a2151b1f9
Attachment #362894 - Attachment description: declare ix before use → declare ix before use [Checkin: Comment 3]
Blocks: 36810
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

8 years ago
Component: General → Session Restore
QA Contact: general → session.restore
You need to log in before you can comment on or make changes to this bug.