479055 - vcsMappings config needs to live in install-specific config file (no source links to 1.9.1 on crash-stats)

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[(not currently active) Ted Mielczarek]

I went looking for the vcsMappings config file, and noticed that it's in application.php, which says "Application-specific settings separate from installation concerns." This is wrong, since these should be configured per-installation. (The values in there are only really valid for Mozilla, and even then they don't account for SeaMonkey.)

Can we get these values moved elsewhere, so we can add entries on the production copy without having to update the code there?

Specifically, we'll need to add an entry for the 1.9.1 repo once we're done, something like:
    'hg' => array(
        'hg.mozilla.org/mozilla-central' =>
            'http://hg.mozilla.org/mozilla-central/annotate/%(revision)s/%(file)s#l%(line)s'
        'hg.mozilla.org/releases/mozilla-1.9.1' =>
            'http://hg.mozilla.org/releases/mozilla-1.9.1/annotate/%(revision)s/%(file)s#l%(line)s'
    )

Comment 1

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Hey guys --

Not being able to see source links in 1.9.1 is making it pretty hard to tell if crashes in similar code are identical or not, and slows down analysis of them.  Would be great to get this fixed soon, let me know if I can help.

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

(To be clear, while I like the sound of the architectural fix here, I'll take any gross and smelly hack that makes the 1.9.1 source links work in the interim.)

Comment 3

[Austin King [:ozten]]

Checked in a fix r1176. Filed IT ticket to stage change.

Comment 4

[Austin King [:ozten]]

Code is on stage.

Comment 5

[(not currently active) Ted Mielczarek]

That doesn't seem to have fixed my original request in this bug, since I still have to file a Socorro bug and not an IT bug to get this updated, which is why bug 510918 is languishing and we don't have source links for 1.9.2 now.