Closed Bug 479082 Opened 12 years ago Closed 12 years ago

AutoComplete should not show unvisited not-bookmarked-elsewhere children of livemark containers

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: sdwilsh, Assigned: adw)

References

Details

Attachments

(1 file)

I'm not sure how to test this offhand, but we need a test that makes sure livemarks get filtered out of autocomplete.
Assignee: nobody → adw
This could probably go in the autocomplete/ tests directory. There isn't any existing code there to add livemarks in that head_* file, but check out..

unit/test_exclude_livemarks.js 

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/unit/test_exclude_livemarks.js
Summary: AutoComplete test for filtering out livemarks → AutoComplete should not show unvisited not-bookmarked-elsewhere children of livemark containers
Attached patch v1Splinter Review
Added an addLivemark function to head_autocomplete.js.  Tests autocomplete on both URIs and titles, not sure if that's necessary.  Not familiar with autocomplete at all, so there are probably problems with this patch...
Attachment #363174 - Flags: review?(sdwilsh)
Comment on attachment 363174 [details] [diff] [review]
v1

r=sdwilsh
Attachment #363174 - Flags: review?(sdwilsh) → review+
http://hg.mozilla.org/mozilla-central/rev/cc82e650a7fa
Status: NEW → RESOLVED
Closed: 12 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Flags: in-testsuite+
Marco - this bug wasn't marked as checkin-needed for a reason...
oh sorry, was a test only and with a review, back it out if needed :\
You need to log in before you can comment on or make changes to this bug.