479082 - AutoComplete should not show unvisited not-bookmarked-elsewhere children of livemark containers

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Shawn Wilsher :sdwilsh]

I'm not sure how to test this offhand, but we need a test that makes sure livemarks get filtered out of autocomplete.

Comment 1

[Ed Lee :Mardak]

This could probably go in the autocomplete/ tests directory. There isn't any existing code there to add livemarks in that head_* file, but check out..

unit/test_exclude_livemarks.js 

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/unit/test_exclude_livemarks.js

Comment 2

[Drew Willcoxon :adw (Away July 17–July 24)]

Attachment: v1

Added an addLivemark function to head_autocomplete.js.  Tests autocomplete on both URIs and titles, not sure if that's necessary.  Not familiar with autocomplete at all, so there are probably problems with this patch...

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 363174 [details] [diff] [review]
v1

r=sdwilsh

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/cc82e650a7fa

Comment 5

[Shawn Wilsher :sdwilsh]

Marco - this bug wasn't marked as checkin-needed for a reason...

Comment 6

[Marco Bonardo [:mak]]

oh sorry, was a test only and with a review, back it out if needed :\