479111 - investigate notification bar color scheme

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

Attachment: screenshot

When implementing the geolocation prompt that uses the notification bar, i found that the notification type "PRIORITY_INFO_HIGH" is a ugly yellow when compared to the rest of the UI in Fennec.

We should run through the notification types and ensure that their colors match the rest of the theme we are using in Fennec.  Also, i just might be using the wrong notification type here (it is the same was what FF uses)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://mxr.mozilla.org/mozilla-central/find?text=&kind=text&string=notification.css

PRIORITY_[WARNING_[LOW|MEDIUM|HIGH]: (so type="geo" too)
  background-color: InfoBackground;
  color: InfoText;

PRIORITY_INFO_[LOW|MEDIUM|HIGH]:
  background-color: -moz-Dialog;
  color: -moz-DialogText;

PRIORITY_CRITICAL_[LOW|MEDIUM|HIGH|BLOCK]:
  background-color: red;
  color: white;

That's the current value for windows && linux.
Mac use images as background and computed rgba as text color.


It should not be hard to override these with css once we have the correct set of colors for the 3 differents types.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

We may not want all three types, but we can figure that out.

Comment 3

[Madhava Enros [:madhava]]

Attachment: replacement color for the yellow bars

lighter blue: #4483d8
darker blue: #396dcb

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: patch

The diff between wince and maemo are for override mac default notification css  which is a bit  different than others.

(+notification, notification[type="warning"])

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Added some padding for the buttons

pushed: https://hg.mozilla.org/mobile-browser/rev/cec33a21c628

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #5)
> Added some padding for the buttons

crap! I've forget it!

Thanks for adding it.

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090922 Fennec/1.0a3

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2a2pre) Gecko/20090922
Fennec/1.0b4pre