479114 - [FIX]Handle page-break frames after we've sorted out our correct parent

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Right now mixing page-break with table pseudos leads us to stick page-break frames all sorts of places where we don't expect them.  Patch coming up fixes the issue.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

Without this patch, the crashtest triggers:

###!!! ASSERTION: Table row has a non-cell child.: 'Not Reached', file /Users/bzbarsky/mozilla/css-frameconst/mozilla/layout/tables/nsTableRowFrame.cpp, line 1420
###!!! ASSERTION: yikes, a non-row child: 'Not Reached', file /Users/bzbarsky/mozilla/css-frameconst/mozilla/layout/tables/nsTableRowFrame.cpp, line 814
###!!! ASSERTION: yikes, a non-row child: 'Not Reached', file /Users/bzbarsky/mozilla/css-frameconst/mozilla/layout/tables/nsTableRowGroupFrame.cpp, line 383
###!!! ASSERTION: Non-row-group primary frame list child of an nsTableFrame?  How come?: 'Not Reached', file /Users/bzbarsky/mozilla/css-frameconst/mozilla/layout/tables/nsTableFrame.cpp, line 2780
###!!! ASSERTION: Non-row-group primary frame list child of an nsTableFrame?  How come?: 'Not Reached', file /Users/bzbarsky/mozilla/css-frameconst/mozilla/layout/tables/nsTableFrame.cpp, line 2780

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 362967 [details] [diff] [review]
Proposed fix

+  // XXXbz should we actually allow page-break frames here?

We probably should, but I won't push the point since page-break shouldn't be implemented by generating frames at all.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yeah; I was worried in particular about pointing them to native anon content...

I can file a followup bug on that.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Same as above, but fixes issue where we were passing the wrong style context to FindXULDisplayData

Comment 5

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/159ff2e4c2eb