479158 - Double-tap zooming doesn't zoom in on the tapped element

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Madhava Enros [:madhava]]

When I doubletap to zoom, quite often nothing happens; sometimes, when something does happen, the result is that I'm left looking at a different part of the page than where I doubletapped, and page boundary is moved such that the page is cut off and there's no way to pan to see it.

Some of this is related to bug 477105.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Sounds like bug 477435. What is the build ID of the build you were testing?

Comment 2

[Brian Crowder]

Madhava:  what's your response to comment #1?

Comment 3

[(dormant account)]

Attachment: Avoid transaction/zoomtoelement unhappyness

Comment 4

[(dormant account)]

Attachment: fixed to use proper page size info

Comment 5

[Stuart Parmenter]

does this need r?

Comment 6

[Brian Crowder]

I assume so, but since it's basically a refactor of one I wrote, someone else should probably do it.

Comment 7

[Brian Crowder]

Comment on attachment 375906 [details] [diff] [review]
fixed to use proper page size info

I think Taras is in static-analysis land, so I'm'a try to get this landed.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 375906 [details] [diff] [review]
fixed to use proper page size info

>diff --git a/chrome/content/CanvasBrowser.js b/chrome/content/CanvasBrowser.js

>   viewportHandler: function viewportHandler(bounds, boundsSizeChanged) {

>+    let cw = this._browser.contentWindow;

this is unused

>+    let [pageW, pageH] = this._effectiveContentAreaDimensions;

can omit the pageH since it's also unused.

>+    let endX = Math.min(elRect.x - margin, pageW - realWidth);

This looks wrong, because realWidth is in page coordinates while pageW is in screen coordinates. Either way, this could use a more elaborate comment since this logic isn't easy to follow.

Comment 9

[Stuart Parmenter]

this is fixed

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED on builds (zoom does occur):

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre

Bug 511898 was found in correspondence with verification of this one.