479164 - "Bug" appears raw in "File a Bug" on index.cgi

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Max Kanat-Alexander]

In the new index.cgi, it doesn't use $terms.Bug, it just uses "Bug" for "File a Bug".

Comment 1

[Max Kanat-Alexander]

I'm really curious how our tests didn't catch this. It's pretty obvious:

<span>File a Bug</span>

Comment 2

[Guy Pyrzak]

Attachment: V1

Comment 3

[Frédéric Buclin]

(In reply to comment #1)
> <span>File a Bug</span>

The regexp in t/009bugwords.t is:

  if (grep /(a?[\s>]bugs?[\s.:;,])/i, $text)

As Bug is followed by < here, it isn't caught by the regexp.

Comment 4

[Frédéric Buclin]

Comment on attachment 363041 [details] [diff] [review]
V1

>-            <span>File a Bug</span>
>+            <span>File a [% terms.Bug %]</span>

Must be terms.abug or terms.ABug.

Comment 5

[Frédéric Buclin]

Attachment: patch, v2

I added terms.aBug to variables.none.tmpl and also fixed t/009bugwords.t to correctly catch "bug" right before an HTML tag.

Comment 6

[Frédéric Buclin]

Must not be checked in before bug 478232 has been landed first, due to conflicts.

Comment 7

[Frédéric Buclin]

Checking in t/009bugwords.t;
/cvsroot/mozilla/webtools/bugzilla/t/009bugwords.t,v  <--  009bugwords.t
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/index.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/index.html.tmpl,v  <--  index.html.tmpl
new revision: 1.43; previous revision: 1.42
done
Checking in template/en/default/global/variables.none.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/variables.none.tmpl,v  <--variables.none.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/pages/release-notes.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/release-notes.html.tmpl,v  <--  release-notes.html.tmpl
new revision: 1.32; previous revision: 1.31
done