479189 - weave does not sync tag smart folders properly

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Axel Taferner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2
Build Identifier: 0.2.100

Tag smart folders are empty on second computer

Reproducible: Always

Steps to Reproduce:
Test Case:
0. Delete all data from weave server
1. Start Firefox with new profile 1
2. Install Weave
3. Create a bookmark with an assigned tag
4. Open Bookmarks Organizer and drag the tag to the Bookmarks toolbar to create a tag smart folder
5. Sign-in and sync with Weave
6. Exit Firefox
7. Start Firefox with new profile 2
8. Install Weave
9. Sign-in and sync with Weave
Actual Results:  
The bookmark has properly sync'd but the tag smart folder in the Bookmarks Toolbar is empty.

Expected Results:  
The tag smart folder in the Bookmarks Toolbar should work and display the bookmark with the tag when clicked.

This is possibly related to Bug 444601
I use tag smart folders extensively to organize my bookmarks. I refuse to go back to regular folders ;)

Comment 1

[Axel Taferner]

screencast of the test case here:
http://www.youtube.com/watch?v=YaYoaZMKKXM

Comment 2

[Axel Taferner]

Attachment: Sync Log 01 from the test case

This is the Sync log of the initial sync.

Comment 3

[Axel Taferner]

Attachment: Sync Log 02 from the test case

This is the Sync log of the sync with second profile.

Comment 4

[Dan Mills [:thunder]]

Fantastic job with the bug, thanks!  We'll reproduce this and find the problem.

Comment 5

[Dan Mills [:thunder]]

-> 0.4

Comment 6

[Mike Connor [:mconnor]]

Need to assess sooner rather than later.

Comment 7

[Ed Lee :Mardak]

It looks like we're correctly syncing smart bookmarks...

But the bookmark uri we're syncing is "place:folder=427&type=7&queryType=1"

So the tag's id changes when we move to a new machine..

Comment 8

[Axel Taferner]

I would like to reiterate the potential relation of this Bug to Firefox Bug 444601

Comment 9

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/87432c5aaa63
Create a new record type, BookmarkQuery, to handle place: uri smart bookmarks. Store what tag name the query wants and lookup the id for that tag on other machines on create/update.

Comment 10

[Ayan Shah[:ashah]]

Investigating this bug for being potential crossweave automation test case candidate.