479292 - Comments scrunched up & crazy looking with new design

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Mary]

Hey there:

If you check out some of the comments in groups they are indented and sort of flow together.

I know the indenting being worked on, but could we use a thin separator line like we do in the current version:  http://www.spreadfirefox.com/mozilla-events

Thanks!

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

I find this pretty distracting lately; Mary, can we block?

This has got to be an almost-trivial fix, I bet.  Paul?

Comment 2

[Alex Buchanan [:abuchanan]]

yeah, feel free to take this.  I won't get a start on it until tomorrow night probably.

Comment 3

[Mary]

Block party!!!

Comment 4

[Neil Lee [:neilio]]

Alex, where's the CSS for this - in the same location? I can add a fix for this...

Comment 5

[Alex Buchanan [:abuchanan]]

Yes, you can put CSS for this bug in css/main.css

Comment 6

[Paul Craciunoiu [:paulc]]

Hey Neil, are you on this? Need my help?

Comment 7

[Neil Lee [:neilio]]

Attachment: Patch to make the comments look less scrunchy

I made a bunch of changes to the comments to make them look better - hopefully this isn't too dramatic a change.

Comment 8

[Neil Lee [:neilio]]

Attachment: Screenshot of the redesign

Here's a screenshot of what the redesigned comments look like - the middle comment shows the new rollover state for the titles. I think removing the link colour from the headings makes the page less noisy, but let me know if this breaks an existing convention.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #8)
> Created an attachment (id=366580) [details]
> Screenshot of the redesign
> 
> Here's a screenshot of what the redesigned comments look like - the middle
> comment shows the new rollover state for the titles. I think removing the link
> colour from the headings makes the page less noisy, but let me know if this
> breaks an existing convention.

What do follow-up comments look like in the expanded view?

Comment 10

[Majken Connor [:Kensie]]

I still find these hard to read, there's not enough distinction between the comment info and the actual content.

I would suggest either indenting the actual comment content or using some sort of background under the heading, maybe reusing the staple graphic.

Comment 11

[Mary]

Hey there:  I think this is a lot better, but would like to see things expanded per comment 9.

Comment 12

[Neil Lee [:neilio]]

@Stephen - got a URL to an exanmple of "expanded view"? I don't have any of
these pages working locally, so I've had to kind of reverse-engineer the page
and don't know where I'd look for these.

@Lucy - I can massage the colours a bit - the comment text colour is pretty
light right now for sure. Indenting the comments would probably make scanning
them more difficult, but reducing the colour of the metadata further and
darkening the comment text might help.

Comment 13

[jamey]

@ Neil you may want to look at the group here

https://spreadfirefox.authstage.mozilla.com/node/378
this is on the bottom should be on the top right side
    *

FoxieWire

    * Group home
    * Group calendar
    * Create Image
    * Create Discussion topic
    * Create Event
    * Create Document
    * Group forums
    * Manage group forums
    * Manage group content types
    * Invite friend
    * 6069 subscribers
    * Manager: graphicsguru
    * My subscription

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

@Neil: https://spreadfirefox.authstage.mozilla.com/campusreps/downloadday#comments

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #13)
> @ Neil you may want to look at the group here

What does that have to do with comments?

Comment 16

[Neil Lee [:neilio]]

@stephen - I don't see any difference between that page and this page: https://spreadfirefox.authstage.mozilla.com/affiliates - am I missing somewthing?

Comment 17

[Mary]

Submitting a bug on comment #13.  Krupa et al. - Let me know if you find other instances of this "side bar" drifting to the bottom.

Comment 18

[Mary]

Neil:  You submitted a patch for this.  Alex:  Can you review?

Comment 19

[Alex Buchanan [:abuchanan]]

Comment on attachment 366579 [details] [diff] [review]
Patch to make the comments look less scrunchy

r23260, a good start.  I'm going to try and clean things up even more this weekend, so leaving this open for now

Comment 20

[Alex Buchanan [:abuchanan]]

r23812 cleans things up a bit more. calling this good for 3.0

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; comments are looking great on:

https://spreadfirefox.authstage.mozilla.com/affiliates
and https://spreadfirefox.authstage.mozilla.com/node/2284#comments

Check out https://spreadfirefox.authstage.mozilla.com/node/3022#comment-2807, too :-)