Closed
Bug 479320
Opened 15 years ago
Closed 15 years ago
JS_STATIC_ASSERT in some situations causes WinCE compilers to barf
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: crowderbt, Assigned: crowderbt)
Details
Attachments
(1 file)
|
674 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
patch next...
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #363196 -
Flags: review?(jorendorff)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 363196 [details] [diff] [review] use __COUNTER__ when available Great. Funny, it seemed like more work than that. :) But JS_SA and JS_SA1 seem unnecessarily terse. The fewer places a name is used (directly), the *longer* it's supposed to be. Or so says Huffman.... r=me with longer identifiers.
Attachment #363196 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Changed the JS_SA macros to JS_STATIC_ASSERT_GLUE instead: http://hg.mozilla.org/mozilla-central/rev/e34bb252511b
|
|
Assignee | |
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•