479382 - libmar doesn't build on windows ce (uses posix file io)

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: gets us building on wince

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I know I've said it before, but maybe we should think about creating a first class library that emulates these basic CRT function instead of putting preprocessor cruft all through the codebase.

Comment 3

[Doug Turner (:dougt)]

nspr would be a good place for such basic CRT functions -- inlined, even.

Comment 4

[Benjamin Smedberg]

Except that libmar can't depend on NSPR...

Comment 5

[Benjamin Smedberg]

Comment on attachment 363642 [details] [diff] [review]
gets us building on wince

>diff --git a/modules/libmar/src/mar_create.c b/modules/libmar/src/mar_create.c

>+#ifdef WINCE
>+    flags = (file_data.dwFileAttributes & FILE_ATTRIBUTE_READONLY) ?
>+      0x0444 : 0x666;

These flags don't look right. Don't you mean 0444, not 0x0444 ? Permissions are typically written in octal, not hex.

>+    size = (file_data.nFileSizeHigh * MAXDWORD) + file_data.nFileSizeLow;

I think you want file_data.nFileSizeHigh * (MAXDWORD + 1) + file_data.nFileSizeLow; 

>diff --git a/modules/libmar/src/mar_extract.c b/modules/libmar/src/mar_extract.c

> /* Ensure that the directory containing this file exists */
> static int mar_ensure_parent_dir(const char *path)
> {
>   char *slash = strrchr(path, '/');
>+#ifdef WINCE
>+  unsigned short wide_path[MAX_PATH];

use wchar_t or WCHAR

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #5)
> 
> >+    size = (file_data.nFileSizeHigh * MAXDWORD) + file_data.nFileSizeLow;
> 
> I think you want file_data.nFileSizeHigh * (MAXDWORD + 1) +
> file_data.nFileSizeLow; 

"The size of the file is equal to (nFileSizeHigh * MAXDWORD) + nFileSizeLow."
according to: http://msdn.microsoft.com/en-us/library/ms915521.aspx

and "The size of the file is equal to (nFileSizeHigh * (MAXDWORD+1)) + nFileSizeLow."
according to: http://msdn.microsoft.com/en-us/library/aa365740%28VS.85%29.aspx

The former is windows ce documentation, and the later is Win32 desktop.  

I'm going to assume the former is a typo, since the later makes more sense.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.2 [Checkin: Comment 8]

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 365993 [details] [diff] [review]
patch v.2
[Checkin: Comment 8]


http://hg.mozilla.org/mozilla-central/rev/0720a4f0eeec

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 365993 [details] [diff] [review]
patch v.2
[Checkin: Comment 8]

a191=beltzner

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c74cb228d2ad