479395 - Columns containing only zeros shouldn't show up in the table

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Statistics, defect, P3)

Description

[Wladimir Palant]

If I go to Adblock Plus statistics and switch to "Add-on Version" I now have a table showing the exact data - thanks for that, dealing with CSV was painful. However, some columns are unnecessary. There is for example the version "0.5.4" (which never existed by the way), it has only zeros. It probably had some pings at some point but that was before the time interval that's being displayed. Columns like this one shouldn't show up, this will make the table easier to read (I can imagine though that other extensions don't have nearly as much trash in their ADU data).

Comment 1

[Dave Garrett]

Same problem with the "Application" table. Old pre versions end up cluttering up the list with columns of all zeros, not to mention versions for stuff I'm not entirely sure even what it is. My table has pages and pages of these. Actually slows loading down a bit.

To a lesser degree this even applies to "Add-on Status". One guy's computer sends in something weird like an unparsed "%ITEM_STATUS%" or "0" or "null" and it's stuck counting them forever.

Comment 2

[Wil Clouser [:clouserw]]

I just added this to the latest spec for the stats dashboard:

support &column= options in the get string so people can specify only columns they care about.  Example:
  /en-US/addon/1865/statistics/os-week-2009-01-01-2009-06-01.csv?column=date&column=count&column=WINNT&column=Linux&column=SunOS

When columns are specifically requested, only those columns are returned and in the order specified.  These requests would always go to gearman.

Comment 3

[Potch [:potch]]

The new stats dashboard that is about to ship only displays columns that have a non-zero value for that page of data.