crash in content iterator while un-attributing text

VERIFIED FIXED

Status

()

P3
critical
VERIFIED FIXED
20 years ago
12 years ago

People

(Reporter: buster, Assigned: buster)

Tracking

Trunk
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

20 years ago
open test case
select from 2-9, make bold (Ctrl-B)
select from 2-8, make italic (Ctrl-I)
select from 2-4, make not bold (Ctrl-B)
crash in content iterator.
it looks like cN is the content node corresponding to <HTML>.  This node has no
parent, but no check is being made to see that GetParent returned a non-null
parent.  I don't think adding the check fixes anything, because we shouldn't be
getting to <HTML> anyway.  We should never be able to iterate above <BODY>,
right?
(Assignee)

Comment 1

20 years ago
here's the simple test case:
<html><body>1234567890abcdefgh</body></html>

Updated

20 years ago
Status: NEW → ASSIGNED

Comment 2

20 years ago
accepting bug

Comment 3

20 years ago
Steve, I think you should redo RemovetextPropertiesForNodeWithDifferentParents()
slightly.  You pass in a range which you use to set up the iter, but before you
use the range you call RemovetextPropertiesForNode() a couple of times and this
can alter the range.

Can you try manually creating a range to specify everything between the start and
end nodes (which are now not where they used to be) and see how that fares?
(Assignee)

Comment 4

20 years ago
looking into it.
(Assignee)

Comment 5

20 years ago
the majority of problems with this code are fixed.  I'm still looking into one
case where GetTextProperty returns the wrong answer depending on whether the
selection starts after the last child of the previous node, or before the first
child of the next node.  After that's fixed, I'll mark this bug fixed.

Updated

20 years ago
Assignee: jfrancis → buster
Status: ASSIGNED → NEW

Comment 6

20 years ago
assigning to Steve
(Assignee)

Updated

20 years ago
Status: NEW → RESOLVED
Last Resolved: 20 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

20 years ago
The originally reported problem is fixed, along with a bunch of related fixes.
Sujay, to keep your job reasonable, just verify the original problem is fixed
(doesn't crash and gives the correct result.)  Any other bugs should be
submitted separately.

Updated

20 years ago
Status: RESOLVED → VERIFIED

Comment 8

20 years ago
verified in 4/20 build...no longer crashing...I used the test case provided.
However, I found another bug..filing separate.

Updated

12 years ago
You need to log in before you can comment on or make changes to this bug.