Closed Bug 479407 Opened 15 years ago Closed 15 years ago

pushlog/pushloghtml broken since updates in 19/Feb downtime

Categories

(mozilla.org Graveyard :: Server Operations, task)

Product:
mozilla.org Graveyard
Component:
Server Operations
Type:
task
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nthomas, Assigned: reed)

References

(
URL
)

Details

The URL has a grey banner only, no list of pushes.
http://hg.mozilla.org/mozilla-central/pushlog isn't working at all (that URL produces the same as http://hg.mozilla.org/mozilla-central/, it should be producing an ATOM feed). That makes this a blocker, as that means no checkins will be picked up on any tinderboxes that are building from any Mercurial repo.
Severity: normal → blocker
Summary: pushloghtml broken since updates in 19/Feb downtime → pushlog/pushloghtml broken since updates in 19/Feb downtime
Firefox/Firefox3.1/Tracemonkey trees are closed for this.
This probably means an internal server error was thrown in the pushlog code. Log output would be helpful.
[Fri Feb 20 04:41:35 2009] [error] [client 10.2.74.16] Traceback (most recent call last):
[Fri Feb 20 04:41:35 2009] [error] [client 10.2.74.16]   File "/usr/lib/python2.4/site-packages/mercurial/util.py", line 310, in increasingchunks
[Fri Feb 20 04:41:35 2009] [error] [client 10.2.74.16]     for chunk in source:
[Fri Feb 20 04:41:35 2009] [error] [client 10.2.74.16]   File "/usr/lib/python2.4/site-packages/mercurial/templater.py", line 148, in expand
[Fri Feb 20 04:41:35 2009] [error] [client 10.2.74.16]     item = iters[0].next()
[Fri Feb 20 04:41:35 2009] [error] [client 10.2.74.16]   File "/usr/lib/python2.4/site-packages/mercurial/templater.py", line 124, in _process
[Fri Feb 20 04:41:35 2009] [error] [client 10.2.74.16]     for i in v:
[Fri Feb 20 04:41:35 2009] [error] [client 10.2.74.16]   File "/repo/hg/extensions/pushlog-feed.py", line 394, in changelist
[Fri Feb 20 04:41:35 2009] [error] [client 10.2.74.16]     ch.append({"author": ctx.user(),
[Fri Feb 20 04:41:35 2009] [error] [client 10.2.74.16] AttributeError: 'hgweb' object has no attribute 'listfilediffs'
Did the version of hg get updated on these boxes? That seems like a bad idea.
yes, it did, from 1.0.2 to 1.1.2.  I just reverted back to the previous version, but it doesn't seem to have helped at all.  Still seeing that same error in the log.
Did you restart the web server after reverting the hg version?
ok, restarted apache and now we get this instead:

[Fri Feb 20 05:07:30 2009] [error] [client ::1] mod_wsgi (pid=21693): Exception occurred processing WSGI script '/repo/hg/webroot_wsgi/hgwebdir.wsgi'.
er, midaired there, I had the same thought. :)
This bustage looks fixed, thanks justdave. We'll file a followup on fixing the pushlog code so you can update to that version of hg at some point.
Assignee: server-ops → justdave
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Oops, guess hgwebdir is still busted?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Also, filed bug 479420 on fixing the pushlog code.
there's multiple backend servers, I've been playing with one of them.  It does look like the errors stopped on that server now, so I'm updating the other one to match now.  Give me a few minutes and we should be clear on both, if we really did get it fixed.
Ok. Looks like we're not using the right templates on hgwebdir: http://hg.mozilla.org/, but since the pushlog is working this is no longer a blocker.
Severity: blocker → major
The first one is still erroring, just way less frequently than before:

[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16] mod_wsgi (pid=16429): Exception occurred processing WSGI script '/repo/hg/webroot_wsgi/hgwebdir.wsgi'.
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16] Traceback (most recent call last):
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]   File "/usr/lib/python2.4/site-packages/mercurial/hgweb/request.py", line 100, in run_wsgi
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]     return application(env, respond)
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]   File "/usr/lib/python2.4/site-packages/mercurial/hgweb/hgwebdir_mod.py", line 74, in __call__
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]     self.run_wsgi(req)
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]   File "/usr/lib/python2.4/site-packages/mercurial/hgweb/hgwebdir_mod.py", line 147, in run_wsgi
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]     req.write(tmpl('error', error=err.message or ''))
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]   File "/usr/lib/python2.4/site-packages/mercurial/hgweb/request.py", line 60, in write
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]     self.write(part)
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]   File "/usr/lib/python2.4/site-packages/mercurial/hgweb/request.py", line 60, in write
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]     self.write(part)
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]   File "/usr/lib/python2.4/site-packages/mercurial/hgweb/request.py", line 60, in write
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]     self.write(part)
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]   File "/usr/lib/python2.4/site-packages/mercurial/hgweb/request.py", line 64, in write
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16]     self.server_write(thing)
[Fri Feb 20 05:20:32 2009] [error] [client 10.2.74.16] IOError: client connection closed
ok, both servers are updated with 1.0.2 now
(In reply to comment #15)
> Ok. Looks like we're not using the right templates on hgwebdir:

what does that mean?  what's left to be done here?
those hgwebdir pages should be using the same templates as the rest of the site, which means they'd be including this template:
http://hg.mozilla.org/hg_templates/file/244027b2b6dd/gitweb_mozilla/index.tmpl
with the "repository layout" links at the bottom.

You can also simply compare the visual style of, say:
http://hg.mozilla.org/hg_templates/
with:
http://hg.mozilla.org/

They should be using the same set of templates, so they should look visually similar.
ok, I've no idea where that would be configured or why that suddenly changed
Assignee: justdave → server-ops
dm-vcview0[123] fixed to use the correct templates directory.
Assignee: server-ops → reed
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Product: mozilla.org → mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.