Closed
Bug 479441
Opened 16 years ago
Closed 16 years ago
outparams analysis breaks on pointer-to-member
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: taras.mozilla)
Details
Attachments
(3 files)
|
983 bytes,
patch
|
Details | Diff | Splinter Review | |
|
3.11 KB,
text/plain
|
Details | |
|
968 bytes,
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
dbaron landed a patch today which uses pointer-to-member variables (not functions). Treehydra/outparams is not liking it. I've prepared a minimal testcase for the suite.
dmandelin/taras, does one of you have time to look at this today?
|
Reporter | |
Comment 1•16 years ago
|
||
|
Assignee | |
Comment 2•16 years ago
|
||
I wish Dave used switch statements instead of if
Assignee: nobody → tglek
Attachment #363344 -
Flags: review?(dmandelin)
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 363344 [details] [diff] [review]
added pretty-printing for offset-type
I wouldn't have minded if you switched to a switch. That if-else series just dates to before you taught me that switch can be used with TREE_CODEs. :-)
It looks like you have a print statement left in, but otherwise looks good.
Attachment #363344 -
Flags: review?(dmandelin) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 5•16 years ago
|
||
I pushed the testcase to mozilla-central also.
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•