Closed Bug 479441 Opened 14 years ago Closed 14 years ago

outparams analysis breaks on pointer-to-member

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: benjamin, Assigned: taras.mozilla)

Details

Attachments

(3 files)

Attached patch TestcaseSplinter Review
dbaron landed a patch today which uses pointer-to-member variables (not functions). Treehydra/outparams is not liking it. I've prepared a minimal testcase for the suite.

dmandelin/taras, does one of you have time to look at this today?
I wish Dave used switch statements instead of if
Assignee: nobody → tglek
Attachment #363344 - Flags: review?(dmandelin)
Comment on attachment 363344 [details] [diff] [review]
added pretty-printing for offset-type

I wouldn't have minded if you switched to a switch. That if-else series just dates to before you taught me that switch can be used with TREE_CODEs. :-) 

It looks like you have a print statement left in, but otherwise looks good.
Attachment #363344 - Flags: review?(dmandelin) → review+
pushed http://hg.mozilla.org/users/tglek_mozilla.com/dehydra-gcc/rev/09a2febe9f67
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
I pushed the testcase to mozilla-central also.
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.