Closed
Bug 479461
Opened 16 years ago
Closed 16 years ago
Private browsing, close window, can't restore session
Categories
(Firefox :: Private Browsing, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 3.1b3
People
(Reporter: theosib, Assigned: mconnor)
Details
(Keywords: verified1.9.1)
Attachments
(1 file)
1.65 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090220 Shiretoko/3.1b3pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090220 Shiretoko/3.1b3pre
A bug regarding private browsing have returned. I'm using the nightly build as of 2009-20-2.
Reproducible: Always
Steps to Reproduce:
1. Have some documents open
2. Enter private browsing mode
3. Close the window
4. Exit private browsing mode
Actual Results:
A window with an empty document is opened
Expected Results:
Should get original session restored
Also, in this state, it thinks you're no longer in private browsing mode.
Work-around: Re-enter private browsing, leave the document open, exit private browsing.
There really should not be any dependency on having a document open in order to properly exit private browsing. I wonder what happens if you have no documents open and you try to ENTER private browsing. Maybe I'll try that.
Updated•16 years ago
|
Component: General → Session Restore
QA Contact: general → session.restore
Version: unspecified → 3.1 Branch
Updated•16 years ago
|
Component: Session Restore → Private Browsing
QA Contact: session.restore → private.browsing
Whiteboard: DUPEME
Assignee | ||
Comment 1•16 years ago
|
||
I don't see a dupe of this, confirming, blocking.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-firefox3.1+
Priority: -- → P1
Target Milestone: --- → Firefox 3.1b3
Assignee | ||
Comment 2•16 years ago
|
||
Mine, we're throwing because there's no browser window open.
Assignee: nobody → mconnor
Status: NEW → ASSIGNED
Assignee | ||
Updated•16 years ago
|
Whiteboard: DUPEME
Assignee | ||
Comment 3•16 years ago
|
||
pretty obvious error checking here
Attachment #364258 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•16 years ago
|
Whiteboard: [has patch][need review gavin]
Assignee | ||
Updated•16 years ago
|
Attachment #364258 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 4•16 years ago
|
||
Comment on attachment 364258 [details] [diff] [review]
don't assume we'll get a browser window
r=gavin over-the-shoulder
Assignee | ||
Updated•16 years ago
|
Whiteboard: [has patch][need review gavin] → [has patch][has reviews]
Comment 5•16 years ago
|
||
Do you want me to land this for you?
Assignee | ||
Comment 6•16 years ago
|
||
If you're landing soon anyway, might as well!
Comment 7•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-litmus?
Resolution: --- → FIXED
Whiteboard: [has patch][has reviews]
Updated•16 years ago
|
Whiteboard: [needs 1.9.1 landing]
Comment 8•16 years ago
|
||
Keywords: fixed1.9.1
Whiteboard: [needs 1.9.1 landing]
Comment 9•16 years ago
|
||
Verified fixed on the 1.9.1 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090302 Minefield/3.2a1pre.
Verified fixed on the trunk using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090302 Minefield/3.2a1pre.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Comment 10•16 years ago
|
||
So in my haste to verify this I realized one thing:
This works when you follow the STR and exit private browsing from the File Menu.
It does not work when you follow the STR and have an intermediary step of first clicking on the dock icon before doing anything else. When you do that, it gives you your home page and you have to exit PB to get your session restored. I can file a new bug for this case.
Comment 11•16 years ago
|
||
This comment can be disregarded. Closing down the window on the mac during PB does not exit the session, so it is expected that when you click on the dock icon after closing a window that you are still technically in the PB session.
(In reply to comment #10)
> So in my haste to verify this I realized one thing:
>
> This works when you follow the STR and exit private browsing from the File
> Menu.
>
> It does not work when you follow the STR and have an intermediary step of first
> clicking on the dock icon before doing anything else. When you do that, it
> gives you your home page and you have to exit PB to get your session restored.
> I can file a new bug for this case.
Comment 12•16 years ago
|
||
Flags: in-litmus? → in-litmus+
Comment 13•16 years ago
|
||
(In reply to comment #12)
> https://litmus.mozilla.org/show_test.cgi?id=7645
This test is Mac-specific, right?
You need to log in
before you can comment on or make changes to this bug.
Description
•