479461 - Private browsing, close window, can't restore session

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect, P1)

Description

[Timothy Miller]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090220 Shiretoko/3.1b3pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090220 Shiretoko/3.1b3pre

A bug regarding private browsing have returned.  I'm using the nightly build as of 2009-20-2.

Reproducible: Always

Steps to Reproduce:
1.  Have some documents open
2.  Enter private browsing mode
3.  Close the window
4.  Exit private browsing mode
Actual Results:  
A window with an empty document is opened

Expected Results:  
Should get original session restored

Also, in this state, it thinks you're no longer in private browsing mode.

Work-around:  Re-enter private browsing, leave the document open, exit private browsing.

There really should not be any dependency on having a document open in order to properly exit private browsing.  I wonder what happens if you have no documents open and you try to ENTER private browsing.  Maybe I'll try that.

Comment 1

[Mike Connor [:mconnor]]

I don't see a dupe of this, confirming, blocking.

Comment 2

[Mike Connor [:mconnor]]

Mine, we're throwing because there's no browser window open.

Comment 3

[Mike Connor [:mconnor]]

Attachment: don't assume we'll get a browser window

pretty obvious error checking here

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 364258 [details] [diff] [review]
don't assume we'll get a browser window

r=gavin over-the-shoulder

Comment 5

[(no longer active)]

Do you want me to land this for you?

Comment 6

[Mike Connor [:mconnor]]

If you're landing soon anyway, might as well!

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/9a08c4c7497f

Comment 8

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/53bc33d54b14

Comment 9

[Marcia Knous [:marcia]]

Verified fixed on the 1.9.1 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090302 Minefield/3.2a1pre.

Verified fixed on the trunk using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090302 Minefield/3.2a1pre.

Comment 10

[Marcia Knous [:marcia]]

So in my haste to verify this I realized one thing:

This works when you follow the STR and exit private browsing from the File Menu.

It does not work when you follow the STR and have an intermediary step of first clicking on the dock icon before doing anything else. When you do that, it gives you your home page and you have to exit PB to get your session restored. I can file a new bug for this case.

Comment 11

[Marcia Knous [:marcia]]

This comment can be disregarded. Closing down the window on the mac during PB does not exit the session, so it is expected that when you click on the dock icon after closing a window that you are still technically in the PB session.

(In reply to comment #10)
> So in my haste to verify this I realized one thing:
> 
> This works when you follow the STR and exit private browsing from the File
> Menu.
> 
> It does not work when you follow the STR and have an intermediary step of first
> clicking on the dock icon before doing anything else. When you do that, it
> gives you your home page and you have to exit PB to get your session restored.
> I can file a new bug for this case.

Comment 12

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7645

Comment 13

[(no longer active)]

(In reply to comment #12)
> https://litmus.mozilla.org/show_test.cgi?id=7645

This test is Mac-specific, right?