Closed Bug 479480 Opened 15 years ago Closed 15 years ago

drop the XP_MAC specific MAX_REFLOW_DEPTH.

Categories

(Core :: DOM: HTML Parser, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dougt, Assigned: dougt)

References

()

Details

Attachments

(1 file)

Attached patch patch v.1Splinter Review
xp_mac isn't defined any longer for this module, and this is dead code.  worse, it is confusing because you have to double check if XP_MAC is defined or not on 10.x.

There might be a need to reset this value for mobile at some point, but we should address that separately.
Attachment #363347 - Flags: review?(joshmoz)
Attachment #363347 - Flags: review?(joshmoz) → review+
Comment on attachment 363347 [details] [diff] [review]
patch v.1

dbaron - any concern here?
Attachment #363347 - Flags: review?(dbaron)
Comment on attachment 363347 [details] [diff] [review]
patch v.1

r=dbaron; XP_MAC hasn't been used for ages
Attachment #363347 - Flags: review?(dbaron) → review+
Comment on attachment 363347 [details] [diff] [review]
patch v.1

@dbaron, josh mentioned that some modules (other code bases?) stil use XP_MAC for their 10.x stuff. :-/
http://hg.mozilla.org/mozilla-central/rev/29db1d75da81
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Blocks: 281889
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: