Closed Bug 479507 Opened 16 years ago Closed 13 years ago

TM: use ASCII codes on typemaps

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: graydon, Assigned: graydon)

References

Details

Currently a tracemonkey typemap entry is a uint8_t that draws some -- but not all -- of its values from spidermonkey jsval tags. This is obscure to a reader (such as myself). It would be plainer and IMO more pleasant if we used simple ASCII codes, such as those already held in the existing typeChar array "OIDVSNB". Pros: debugging is a bit easier, since a typemap is a string; readers of the code don't get mislead into thinking typemap codes are appropriate in jsval tag contexts or vice-versa. Cons: probably more explicit conversions in the code (arguably a good thing), denies the opportunity to "compress" typemaps down to 4 bits as a space optimization in the future.
Blocks: 497207
Obsolete with the removal of tracejit.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.