479565 - Inspector cannot be started again without the need of reopening the overlay again

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090219 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090219020454 and MozMill trunk

Currently its not possible to restart the inspector again after it was stopped by a click/double click in the browser window. You have to close and open the inspector overlay again.

We should simply give the first button two states. Start and Stop. Buttons should also be keyboard accessible.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Oh and the tab order is completely broken in this overlay.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Further the inspector is not disabled when the overlay gets closed. You definitely have to do a click/double click.

Comment 3

[Mikeal Rogers [:mikeal] (mrogers@)]

What do you mean by "the tab order is completely broken" ?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #3)
> What do you mean by "the tab order is completely broken" ?

Better: the tab order is reversed. You navigate backwards through the elements in this dialog.

Comment 5

[Adam Christian]

Committed revision 367. The original bug is fixed.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yeah, everything is fixed except the tab order. I'll file a new bug on that.