479576 - Port Thunderbird Bug 449560 – Accessibility: Give header email labels (From/To/CC) ARIA label properties in message reading window/pane

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Marco Zehe (:MarcoZ)]

Lim Yuen Hoe of the univeristy of Singapore created this patch for Thunderbird, and it just landed there. Since the SeaMonkey mail reader is very similar, I ported (or rather, copy and pasted) the patch and request that SeaMonkey also include this bugfix, which will increase accessibility.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Ported patch

Basically the same patch as in Thunderbird, with one modification: The header type label already contains a colon and a space, so don't add them here since that would add extraneous stuff that's not needed.

Comment 2

[Ian Neal]

Comment on attachment 363464 [details] [diff] [review]
Ported patch

It might be worth just adding in the comment why we don't have to put a colon and space in.

Comment 3

[Marco Zehe (:MarcoZ)]

(In reply to comment #2)
> It might be worth just adding in the comment why we don't have to put a colon
> and space in.

Done, thanks!

Comment 4

[Marco Zehe (:MarcoZ)]

Pushed:
http://hg.mozilla.org/comm-central/rev/b65ce77398b0

Comment 5

[Philip Chee]

I think for SeaMonkey/MailNews you need a sr

Comment 6

[Marco Zehe (:MarcoZ)]

Oops, this was in suite/mailnews, not in the root mailnews folder, so I thought this didn't need SR. The module owner's page didn't specify it either.

Comment 7

[Karsten Düsterloh]

moa+=me after-the-fact, but please ask for sr next time. ;-)

Comment 8

[Marco Zehe (:MarcoZ)]

Thanks, will do! And sorry about that!

Comment 9

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1b3pre) Gecko/20090301 SeaMonkey/2.0b1pre.