Closed Bug 479598 Opened 11 years ago Closed 11 years ago

About dialog's user agent field should always be LTR

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.6a1

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

(Keywords: fixed1.9.1, rtl)

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (v1) (obsolete) — Splinter Review
About dialog's user agent field should always be LTR, even for RTL locales, because it displays English text.
Attachment #363475 - Flags: review?(dao)
Comment on attachment 363475 [details] [diff] [review]
Patch (v1)

Similarly to bug 479588, I'd prefer if we'd fix this in aboutDialog.css or introduce a more generic alias for uri-element.
Attachment #363475 - Flags: review?(dao) → review+
Attached patch Patch (v2)Splinter Review
Attachment #363475 - Attachment is obsolete: true
Attachment #366198 - Flags: review?(dao)
Comment on attachment 366198 [details] [diff] [review]
Patch (v2)

without !important
Attachment #366198 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/358fc383efe7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Comment on attachment 366198 [details] [diff] [review]
Patch (v2)

Small theme-only change useful for RTL locales.
Attachment #366198 - Flags: approval1.9.1?
Attachment #366198 - Flags: approval1.9.1? → approval1.9.1+
No longer blocks: intl.css-cleanup
You need to log in before you can comment on or make changes to this bug.