Closed Bug 479625 Opened 13 years ago Closed 13 years ago

Avoid unnecessary work and long-lived strings in nsDOMWorkerMessageEvent

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

(Keywords: fixed1.9.1, perf)

Attachments

(1 file)

Attached patch Patch, v1Splinter Review
Found this while sharking a worker/video demo, we hold the json string data around after we've successfully converted it to a jsval. Also didn't adequately prevent trying to convert multiple times. Attached patch seems to make us GC less often with heavy use of json messages.
Attachment #363498 - Flags: superreview?(jst)
Attachment #363498 - Flags: review?(jst)
Attachment #363498 - Flags: superreview?(jst)
Attachment #363498 - Flags: superreview+
Attachment #363498 - Flags: review?(jst)
Attachment #363498 - Flags: review+
Attachment #363498 - Flags: approval1.9.1+
Comment on attachment 363498 [details] [diff] [review]
Patch, v1

Trivial, low risk, and pretty high gain. a=jst
Pushed rev e74b36d547de to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: needs 1.9.1 landing
Pushed revision 37cd83ef1700 to mozilla-1.9.1.
Keywords: fixed1.9.1
Whiteboard: needs 1.9.1 landing
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.