Test cases that assume more than they should

VERIFIED FIXED

Status

Tamarin
Virtual Machine
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Lars T Hansen, Assigned: Lars T Hansen)

Tracking

(Blocks: 1 bug)

unspecified
Bug Flags:
flashplayer-triage +

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 363501 [details] [diff] [review]
patch for the three problems

Some test cases assume more than they should.  Here are three:

- one is testing for an undefined name and assumes that 'eval' is not
  defined, but should test some less likely identifier. I found this
  when I was working on implementing 'eval'.

- the other two assume that serial numbers assigned to function names are
  predictable and meaningful, when they are in fact dependent on the algorithms
  the compiler uses for laying out the ABC file and the algorithms used by
  the verifier to recreate internal data structures.  The test should instead
  check some more general condition, for example that function names correspond
  to a particular expected pattern.  I found this when I was working on
  implementing 'eval'; the run-time compiler lays out the ABC differently.
Attachment #363501 - Flags: review?(dschaffe)

Comment 1

10 years ago
Comment on attachment 363501 [details] [diff] [review]
patch for the three problems

approved patch. looks good.  using regexp [object Function-[0-9]+ is much better than verifying [object Function-3].  We have had to change the value.
Attachment #363501 - Flags: review?(dschaffe) → review+

Updated

10 years ago
Flags: flashplayer-triage+
(Assignee)

Comment 2

10 years ago
changeset:   1486:4bacaca1522f
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.