479660 - Tinderbox "Build Error Summary" does not include crashtest crash

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Jesse Ruderman]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1235268007.1235274191.14714.gz&fulltext=1

TinderboxPrint shows the crashtest fail, but the "summary" does not, so I have to load the full log and search for "TinderboxPrint" to find out which test the crash was after :(

This might be a dup of bug 457976.

Comment 1

[(not currently active) Ted Mielczarek]

This could be a releng bug (to change/add the output there), or a Webtools:Tinderbox bug (to change ep_unittest.pl to pick this up for the summary).

Comment 2

[[e-mail] (:bhearsum)]

I've got a couple of ideas here.

Comment 3

[[e-mail] (:bhearsum)]

Attachment: always print an error message for unittest steps that return non-zero

I went with 'Unknown Error:' here because it seems that 'Error:' won't be picked up by ep_unittest.pl (/\WError: /i). Anyways, this should catch all crashes in any of the unittest steps and give them a more useful Brief Log.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 363690 [details] [diff] [review]
always print an error message for unittest steps that return non-zero

+            if "program finished with exit code" in line:

Is this necessary given the return code check?

Comment 5

[[e-mail] (:bhearsum)]

(In reply to comment #4)
> (From update of attachment 363690 [details] [diff] [review])
> +            if "program finished with exit code" in line:
> 
> Is this necessary given the return code check?

Good point. I should be able to just check the return code outside the loop and construct the line manually.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: check the exit code outside of the loop

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 363945 [details] [diff] [review]
check the exit code outside of the loop

changeset:   205:f85737806a5c

Comment 8

[[e-mail] (:bhearsum)]

master reconfig'ed for this.

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #7)
> (From update of attachment 363945 [details] [diff] [review])
> changeset:   205:f85737806a5c

Ftr,
http://hg.mozilla.org/build/buildbotcustom/rev/f85737806a5c
itself is empty:
somehow, this patch content got merged into the previous check-in:
http://hg.mozilla.org/build/buildbotcustom/rev/c2484f6c012e