Closed Bug 479709 Opened 11 years ago Closed 11 years ago

"Conditional jump or move depends on uninitialised value" in nsSyncLoader::~nsSyncLoader

Categories

(Core :: XSLT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: mats)

Details

(Keywords: fixed1.9.1, testcase, valgrind)

Attachments

(1 file)

Steps to reproduce:
1. Load content/xslt/crashtests/226425.xml with Firefox under Valgrind.

Result:
==56591== Conditional jump or move depends on uninitialised value(s)
==56591==    at 0x19879285: nsSyncLoader::~nsSyncLoader() 
==56591==    by 0x19878D94: nsSyncLoader::Release() 
==56591==    by 0x1987AADC: nsRefPtr<nsSyncLoader>::~nsRefPtr() 
==56591==    by 0x1987A6D7: LoadFromChannel(nsIChannel*, nsIPrincipal*, int, int, nsIDOMDocument**) 
==56591==    by 0x1987A8D2: nsSyncLoadService::LoadDocument(nsIURI*, nsIPrincipal*, nsILoadGroup*, int, nsIDOMDocument**) 
==56591==    by 0x199B9E22: txParseDocumentFromURI 
==56591==    by 0x199E666B: txExecutionState::retrieveDocument(nsAString_internal const&) 
==56591==    by 0x19A19266: retrieveNode(txExecutionState*, nsAString_internal const&, nsAString_internal const&, txNodeSet*) 
==56591==    by 0x19A19943: DocumentFunctionCall::evaluate(txIEvalContext*, txAExprResult**) 
==56591==    by 0x199F1D0C: txPushNewContext::execute(txExecutionState&) 
==56591==    by 0x19A171B8: txXSLTProcessor::execute(txExecutionState&) 
==56591==    by 0x19A2E83F: txMozillaXSLTProcessor::TransformToDoc(nsIDOMDocument*, nsIDOMDocument**) 


Happens under both opt and debug; the output above is from a debug build on Mac.  Running debug builds currently requires a small NSPR patch; see http://blog.mozilla.com/nnethercote/2009/02/17/valgrind-mac-os-x-update-feb-17-2009/#comment-25

Could it be that mLoading was never initialized?
Flags: in-testsuite+
Attached patch Patch rev. 1Splinter Review
Assignee: nobody → mats.palmgren
Attachment #363632 - Flags: superreview?(jonas)
Attachment #363632 - Flags: review?(jonas)
OS: Mac OS X → All
Hardware: x86 → All
Attachment #363632 - Flags: superreview?(jonas)
Attachment #363632 - Flags: superreview+
Attachment #363632 - Flags: review?(jonas)
Attachment #363632 - Flags: review+
Attachment #363632 - Flags: approval1.9.1+
http://hg.mozilla.org/mozilla-central/rev/b4c291560b2d
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/404c6fd3c7a6

-> FIXED
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.