Closed
Bug 479728
Opened 16 years ago
Closed 16 years ago
Rename AsyncExecute
Categories
(Core :: SQLite and Embedded Database Bindings, defect)
Core
SQLite and Embedded Database Bindings
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
Details
Attachments
(1 file)
|
9.47 KB,
patch
|
asuth
:
review+
|
Details | Diff | Splinter Review |
We need to have a better name so folks other than me know what's running. I haven't thought of one yet.
|
Assignee | |
Comment 1•16 years ago
|
||
Settled on AsyncExecuteStatements.
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [needs review asuth]
|
||
Comment 2•16 years ago
|
||
Comment on attachment 367121 [details] [diff] [review]
v1.0
The storage change is fine, but some places code is making a break for it and must be stopped before it escapes...
>diff --git a/toolkit/components/places/src/nsNavHistory.cpp b/toolkit/components/places/src/nsNavHistory.cpp
>diff --git a/toolkit/components/places/src/nsNavHistoryExpire.cpp b/toolkit/components/places/src/nsNavHistoryExpire.cpp
>diff --git a/toolkit/components/places/tests/unit/test_adaptive.js b/toolkit/components/places/tests/unit/test_adaptive.js
Attachment #367121 -
Flags: review?(bugmail) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
(In reply to comment #2)
> The storage change is fine, but some places code is making a break for it and
> must be stopped before it escapes...
I think hg has gone mad on my system...
|
|
Assignee | |
Updated•16 years ago
|
Whiteboard: [needs review asuth]
|
|
Assignee | |
Comment 4•16 years ago
|
||
Pushed the sensible, non-crazy version.
http://hg.mozilla.org/mozilla-central/rev/ea1ed21e882e
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
||
Updated•16 years ago
|
Keywords: dev-doc-needed
|
||
Updated•1 year ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•