479728 - Rename AsyncExecute

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Shawn Wilsher :sdwilsh]

We need to have a better name so folks other than me know what's running.  I haven't thought of one yet.

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Settled on AsyncExecuteStatements.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 367121 [details] [diff] [review]
v1.0

The storage change is fine, but some places code is making a break for it and must be stopped before it escapes...

>diff --git a/toolkit/components/places/src/nsNavHistory.cpp b/toolkit/components/places/src/nsNavHistory.cpp
>diff --git a/toolkit/components/places/src/nsNavHistoryExpire.cpp b/toolkit/components/places/src/nsNavHistoryExpire.cpp
>diff --git a/toolkit/components/places/tests/unit/test_adaptive.js b/toolkit/components/places/tests/unit/test_adaptive.js

Comment 3

[Shawn Wilsher :sdwilsh]

(In reply to comment #2)
> The storage change is fine, but some places code is making a break for it and
> must be stopped before it escapes...
I think hg has gone mad on my system...

Comment 4

[Shawn Wilsher :sdwilsh]

Pushed the sensible, non-crazy version.
http://hg.mozilla.org/mozilla-central/rev/ea1ed21e882e

Comment 5

[Shawn Wilsher :sdwilsh]

No need for docs on this.