Closed Bug 479762 Opened 11 years ago Closed 11 years ago

sed: command garbled for SOURCE_REPO

Categories

(Firefox Build System :: General, defect)

All
Solaris
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

References

Details

Attachments

(1 file, 1 obsolete file)

In browser/app, run make on Solaris 10
Got sed: command garbled error in terminal.

I found similar code in toolkit/xre/Makefile.in and toolkit/content/Makefile.in.
Should we copy it to browser/app/Makefile.in?

+# strip a trailing slash from the repo URL because it's not always present,
+# and we want to construct a working URL in buildconfig.html
+# make+shell+sed = awful
+_dollar=$$
+SOURCE_REPO := $(shell cd $(topsrcdir) && hg showconfig paths.default 2>/dev/null | head -n1 | sed -e "s/^ssh:/http:/" -e "s/\/$(_dollar)//" )
+
Attached patch patch (obsolete) — Splinter Review
Attachment #363662 - Flags: review?(ted.mielczarek)
Just curious, what exactly doesn't your sed like about the existing command?
s/^ssh:/http:/ needs to be quoted or "^" needs to be escaped.

"^" is pipe symbol, as same as "|",  for some old shells, like Solaris /bin/sh.
Comment on attachment 363662 [details] [diff] [review]
patch

Can you just make the minimal change needed to fix this here? I think it's probably just changing:
sed s/^ssh:/http:/
to:
sed -e "s/^ssh:/http:/"
Attachment #363662 - Flags: review?(ted.mielczarek) → review-
Attached patch patch v2Splinter Review
Assignee: nobody → ginn.chen
Attachment #363662 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #364038 - Flags: review?(ted.mielczarek)
Attachment #364038 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/3270fd0db0f0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 496860
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.