479984 - navigation screen (awesomebar) doesn't open when URL field tapped

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

the navigation screen (with the awesomebar and the search engines) doesn't appear when the titlebar is tapped.  It seems to require typing before anything happens.

Comment 1

[Madhava Enros [:madhava]]

I should add, this is with a build from Feburary 24, 2009, on an n810.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

The problem is that we're not marking pages as visited the same way Firefox is, so the default "typed+visited entries" autocomplete query didn't have any results to return, so we didn't open the popup. I suppose this regressed because of bug 426864.

This fix makes us mark pages that were explicitly loaded by the user as "visited", the same way Firefox does.

http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/utils.js#769

gotoURI covers most of the important cases (bookmark selection, URL bar typing, etc.). This means you'll need to actually "type in" a bunch of pages before we start showing the popup again, but that will happen naturally as you use the browser. I also removed an unused gContentBox getter.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mobile-browser/rev/18a766fe070c

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on builds:


Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre