Closed
Bug 480074
Opened 17 years ago
Closed 17 years ago
Better dependency resolution for import libraries
Categories
(NSPR :: NSPR, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
Details
Attachments
(1 file, 1 obsolete file)
|
1011 bytes,
patch
|
Details | Diff | Splinter Review |
NSPR has rules to install export libraries, but no rules that specify how they are created. It happens that gmake allows this because of the order in which dependencies are resolved, but it's better (and helps pymake) if this is done explicitly. The patch is quite simple!
Attachment #364020 -
Flags: review?(ted.mielczarek)
|
||
Updated•17 years ago
|
Attachment #364020 -
Flags: review?(ted.mielczarek) → review+
|
|
||
Comment 1•17 years ago
|
||
Comment on attachment 364020 [details] [diff] [review]
Specify that IMPORT_LIBRARY depends on (and happens to be made by) the $(SHARED_LIBRARY) rules, rev. 1
+ifeq (,$(filter-out WIN95 WINCE OS2,$(OS_TARGET)))
The OS2 is redundant because you're in an else block from OS2 already.
|
Assignee | |
Comment 2•17 years ago
|
||
Updated per nit.
Attachment #364020 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•17 years ago
|
||
Checked in on NSPR HEAD:
Checking in config/rules.mk;
/cvsroot/mozilla/nsprpub/config/rules.mk,v <-- rules.mk
new revision: 3.71; previous revision: 3.70
done
You need to log in
before you can comment on or make changes to this bug.
Description
•