Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Provide tests for SeaMonkey sessionstore

RESOLVED FIXED

Status

SeaMonkey
Session Restore
RESOLVED FIXED
9 years ago
6 years ago

People

(Reporter: Misak Khachatryan, Assigned: Misak Khachatryan)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 4 obsolete attachments)

(Assignee)

Description

9 years ago
I've decided to file separate bug for SM sessionstore tests and leave bug 448976 alone.
(Assignee)

Updated

9 years ago
Blocks: 480110
(Assignee)

Comment 1

9 years ago
Created attachment 364087 [details] [diff] [review]
tests

Port of all sessionstore tests. Currently failing only undo close tab related tests due SM specific implementation of that function.
Attachment #364087 - Flags: review?(ajschult)
No longer blocks: 480110
Depends on: 480110

Updated

8 years ago
Component: UI Design → Session Restore
QA Contact: ui-design → session.restore
(Assignee)

Comment 2

8 years ago
Created attachment 428212 [details] [diff] [review]
v2

It's been a while i didn't update this patch, now they ready.
Attachment #364087 - Attachment is obsolete: true
Attachment #428212 - Flags: review?(neil)
Attachment #364087 - Flags: review?(ajschult)

Comment 3

8 years ago
Comment on attachment 428212 [details] [diff] [review]
v2

> 	browser_bug524369.js \
> 	browser_bug524371.js \
> 	browser_bug524371_sample.html \
>+	browser_339445.js \
>+	browser_339445_sample.html \
>+	browser_345898.js \
Why the change in naming scheme?

>+	browser_476161.js \
>+	browser_476161_sample.html \
Missing?
(Assignee)

Comment 4

8 years ago
Created attachment 428376 [details] [diff] [review]
v3

Added missing test, renamed all files SeaMonkey way.
Attachment #428212 - Attachment is obsolete: true
Attachment #428376 - Flags: review?(neil)
Attachment #428212 - Flags: review?(neil)

Comment 5

8 years ago
Well, my tests build has been crashing lately, which may or may not have caused 339445 to fail; 346337 failed but maybe my tree wasn't up-to-date (it was last updated last week); 524365 threw an exception; 524369 had three failures.
(Assignee)

Comment 6

8 years ago
346337 is definitely needs Bug 547710 patch, which landed yesterday, 524365 and 524369 are not a part of this patch. 339445 is failing for me too, investigating ...
(Assignee)

Updated

8 years ago
Depends on: 548496

Comment 7

8 years ago
(In reply to comment #5)
> Well, my tests build has been crashing lately, which may or may not have caused
> 339445 to fail; 346337 failed but maybe my tree wasn't up-to-date (it was last
> updated last week); 524365 threw an exception; 524369 had three failures.
In a build from 40 hours ago, 524365 is still throwing an exception and 339445 is still failing. But didn't I see someone submit a patch for that exception?
(Assignee)

Comment 8

8 years ago
I have bunch of patches with checkin-needed patch, waiting to be checked in. With them, 524365 and 339445 passing clean. I'll add a comment when they all land.
(Assignee)

Comment 9

8 years ago
sorry with checkin-needed flag of course
It looks like this patch needs a new naming scheme update: to sync' with FF. Thanks.
(Assignee)

Comment 11

8 years ago
Of course, i'll also need to update some tests too. Patch coming ...
(Assignee)

Comment 12

8 years ago
Created attachment 432509 [details] [diff] [review]
v4

added new tests
renamed all tests to original ff bug numbers, mintioning in bug ported bug number, as agreed (except for bug 515006 - there is depended bug, so i decided to leave it for now)
all tests synced to ff ones.
Attachment #428376 - Attachment is obsolete: true
Attachment #432509 - Flags: review?(neil)
Attachment #428376 - Flags: review?(neil)
Comment on attachment 432509 [details] [diff] [review]
v4

>+	browser_bug423132.js \
>+	browser_bug423132_sample.html \
> 	browser_bug431826.js \
>+        browser_bug447951.js \
These should all use tabs, but some of them don't.

>+        tab3 = tabbrowser.undoCloseTab(0);
Nit: undeclared variable.
Attachment #432509 - Flags: review?(neil) → review+
(Assignee)

Comment 14

7 years ago
Created attachment 433717 [details] [diff] [review]
for checkin

nits fixed, carrying forward r+ from Neil.
Attachment #432509 - Attachment is obsolete: true
Attachment #433717 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Assignee)

Comment 15

7 years ago
checkin ping
(In reply to comment #15)

See bug 542946 comment 11...
(Assignee)

Comment 17

7 years ago
Created attachment 435553 [details] [diff] [review]
rename all related tests

This patch renames all related test files as Serge wants, should be applied over main tests patch. So main patch can be checked in meanwhile.
Attachment #435553 - Flags: review?(neil)

Updated

7 years ago
Attachment #435553 - Flags: review?(neil) → review+
(In reply to comment #17)
> This patch renames all related test files as Serge wants, should be applied
> over main tests patch. So main patch can be checked in meanwhile.
I'd prefer both patches pushed in one commit, to reduce history spew ;-)

Comment 19

7 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/9c1e65314027 and http://hg.mozilla.org/comm-central/rev/6bd4bb3b4b5d - I'll leave it to Misak to mark the bug fixed. :)
Keywords: checkin-needed
(In reply to comment #19)

Nits, just ftr:
*In Makefile.in, I would have used 1-tab or 2-spaces rather than 8-spaces.
*Patches were not folded together per comment 18.

Anyway, thanks for these tests :-)
(Assignee)

Comment 21

7 years ago
Thanks Serge, i'll fix it on next test commit.

No problems noted so far, marking FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Blocks: 725679
You need to log in before you can comment on or make changes to this bug.