If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

import Outlook Express newsgroups (OE OEXP)

ASSIGNED
Assigned to

Status

MailNews Core
Import
ASSIGNED
9 years ago
2 years ago

People

(Reporter: Phil Lacy, Assigned: Phil Lacy)

Tracking

unspecified
x86
Windows XP
Bug Flags:
blocking-thunderbird3 -
wanted-thunderbird3 +

Firefox Tracking Flags

(blocking-thunderbird3.1 -)

Details

(Whiteboard: [patchlove][needs updated patch][stalled])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090223 Shredder/3.0b3pre

import newsgroups

Reproducible: Always




working on patch
(Assignee)

Comment 1

9 years ago
Created attachment 364711 [details] [diff] [review]
on importing NNTP, add the newsgroups

imports newsgroups.
Also adds another (minor) fix to closed bug. See https://bugzilla.mozilla.org/show_bug.cgi?id=470725#c56
Attachment #364711 - Flags: review?(neil)

Updated

9 years ago
Assignee: nobody → philbaseless-firefox
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Comment 2

9 years ago
Sorry for taking so long to look at this. I take it folders.dbx contains a list of all groups and the servers that they are subscribed to? Do we currently import all the servers already?
(Assignee)

Comment 3

9 years ago
yes the folders.dbx has a tree of all active folders as is visible in the folder tree view.

The servers are imported under the doNNTPserver() and the groups are done there as well.
(Assignee)

Comment 4

9 years ago
Created attachment 367696 [details]
picture of OE and shredder folders tree

png of side-by-side of shredder and OE NG's
(Assignee)

Comment 5

9 years ago
Neil if you don't find any changes needed, before check-in can you fix the following

-       if (nntpServer && sgPairs.Length() >> 0){
+       if (nntpServer && sgPairs.Length() > 0){

located here line @ 728
https://bugzilla.mozilla.org/attachment.cgi?id=364711&action=diff#a/mailnews/import/oexpress/nsOESettings.cpp_sec5
Phil: If you set the keyword checkin-needed if the patch gets r+ make sure to upload a new patch with that change to make it easier for the person checking this in.
(Assignee)

Comment 7

9 years ago
Created attachment 368828 [details] [diff] [review]
shift >> should have been comparison op >

Frank, I haven't got a r+ yet. But I made the fix now.
Attachment #364711 - Attachment is obsolete: true
Attachment #368828 - Flags: review?(neil)
Attachment #364711 - Flags: review?(neil)
(Assignee)

Updated

9 years ago
Flags: wanted-thunderbird3?
(Assignee)

Comment 8

9 years ago
It would be nice to get it on a beta. It should complete OE import needs.
(Assignee)

Updated

8 years ago
Flags: blocking-thunderbird3?
(Assignee)

Comment 9

8 years ago
Comment on attachment 368828 [details] [diff] [review]
shift >> should have been comparison op >

>         rv = in->SetPrettyName(prettyName);
>+
>+      if (nntpServer && sgPairs.Length() > 0){
>+        for (PRUint32 i = 0; i < sgPairs.Length(); ++i)

need space here: ){

>+    if (!nsOE5File::ReadBytes(inputStream, idxDataBlock,
>+                   pFoldersArray[j]+sizeof FLDRHDR + 4 * fldrHdr.nentries,
>+                   idxDataBlockSize)){

and here

>+  }
>+  for (PRUint32 i = ngData.Length()-1; i > 0 ; --i){
>+    if (ngData[i].flags & 0x400) { // nntp server flag-parent folder
>+      PRUint32 parent = ngData[i].id;
>+      for (PRUint32 j = ngData.Length()-1; j > 0 ; --j)
>+        if (ngData[j].parentID == parent){
>+          SERVERGROUP temp;
>+          temp.server = ngData[i].name;
>+          temp.ng = ngData[j].name;
>+          sgPairs->AppendElement(temp);
>+        }

here as well. The first for loop doesn't need a brace except for legibility due to compound type statements. Also other places may be similar and will need a decision on review
We wouldn't block on this as it isn't a frequently used option and worst case manually importing newsgroups is generally not too hard (or even necessary) for the majority of users. Still would like to have the fix though.
Flags: wanted-thunderbird3?
Flags: wanted-thunderbird3+
Flags: blocking-thunderbird3?
Flags: blocking-thunderbird3-
Whiteboard: [needs review neil]
(Assignee)

Comment 11

8 years ago
can we block now
(Assignee)

Updated

8 years ago
blocking-thunderbird3.1: --- → ?
Flags: blocking-thunderbird3.1?
Generally speaking, newsgroups are not a super high priority for us these days, so we are unlikely to block releases on bugs in that space unless they are exceedingly bad, security holes, or, in some cases, regressions.
blocking-thunderbird3.1: ? → -
Flags: blocking-thunderbird3.1?

Updated

6 years ago
Whiteboard: [needs review neil] → [patchlove][needs updated patch][stalled]

Comment 13

2 years ago
I doubt we care at all about accepting anything against OE anymore.
Is there a modern equivalent that we would care about?
What do you think?
Flags: needinfo?(mozilla)

Comment 14

2 years ago
Comment on attachment 368828 [details] [diff] [review]
shift >> should have been comparison op >

cancelling review pending further info/updated patch
Attachment #368828 - Flags: review?(neil)

Comment 15

2 years ago
(In reply to Wayne Mery (:wsmwk, use Needinfo for questions) from comment #13)
> I doubt we care at all about accepting anything against OE anymore.
Agreed. Outlook Express died with Windows XP.

> Is there a modern equivalent that we would care about?
> What do you think?
For later versions of Windows there is Windows Live Mail, see bug 561562, and in Windows 8.x and 10 we have the Windows Mail app.

Since most e-mail is IMAP these days, import is not such an important issue.
Flags: needinfo?(mozilla)
You need to log in before you can comment on or make changes to this bug.