When using Save Page As with bugzilla attachments, the default filename is attachment.cgi, not the real file name.
This is totally my fault. Gotta love try/catch.
Assignee: nobody → bzbarsky
Summary: "Save Page As" doesn't give the filename of the bugzilla attachment → [FIX]"Save Page As" doesn't give the filename of the bugzilla attachment
Created attachment 364318 [details] [diff] [review] I wish we had tests for this
Attachment #364318 - Flags: review?(gavin.sharp)
Attachment #364318 - Flags: review?(gavin.sharp) → review+
Is there actually more than one expected error, so the catch block can't just check for that and rethrow any other errors?
Dunno. Looking at nsDOMWindowUtils::GetDocumentMetadata I wouldn't expect this code to ever get an exception to start with, so I have no idea why someone stuck a try/catch here.
Ah, that first checkin had the try/catch because the "get to window utils" part could throw.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.