480323 - [FIX]Always create trailing inline for {ib} splits

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Our current behavior of not creating one increases complexity, and looks to be wrong per spec in any case.  Patch coming up.

One concern is anchors containing blocks.  With this patch we'll get a dot for the outline around the trailing inline just like we get one for the leading inline already... I had to adjust the tests for bug 424236 accordingly.  I think we might want to suppress outline on empty special inlines, maybe.  In any case, that would be a separate bug.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

You may need to tweak getBoundingClientRect/getClientRect mochitests too.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Oh, hmm.  I should in fact run mochitest on this patch.  Will do.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Passing mochitest

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Minor tweak: when appending to an {ib} split, continue appending to the block if the trailing inline is empty

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 364578 [details] [diff] [review]
Minor tweak: when appending to an {ib} split, continue appending to the block if the trailing inline is empty

David says he's ok with this in principle, and ok with roc doing the review.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/6feb1a304aef

Comment 8

[Boris Zbarsky [:bzbarsky]]

This caused bug 481769 because we don't treat the ib siblings as in-flows when painting backgrounds.  We should.