480370 - No confirmation or undo on delete of folders in Bookmarks

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Al Billings [:abillings - ex-MoCo]]

If a user creates a subfolder within the Bookmarks main folder and moves bookmarks into it, they can go into edit mode, click on the "x" icon to delete the folder and it is just gone. There is no confirmation before deletion nor any way to undo it, even though the user just deleted a non-empty folder containing bookmarks. We need to ask for confirmation and possibly include undo.

This was found in the 20090226 1.0a3pre build running on my n810.

Steps to Reproduce
1. Have a series of bookmarks and open the bookmarks menu
2. Create a subfolder in the bookmarks menu
3. Move one or more bookmarks into the subfolder after entering manage mode.
4. In manage mode, select the "x" icon to delete the subfolder.

Result: Folder is deleted with no request for confirmation and no means to undo.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

this could be a pain point for users.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I could live with an undo, if we had a way of adding it to the UI. A confirmation dialog is just a pain

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I had an idea for this. We could display a notification box that the user could use to "undo" the delete.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

We can undo(In reply to comment #3)
> I had an idea for this. We could display a notification box that the user could
> use to "undo" the delete.

This notification box should be only for the _last_ deleted bookmarks right?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)
> We can undo(In reply to comment #3)
> > I had an idea for this. We could display a notification box that the user could
> > use to "undo" the delete.
> 
> This notification box should be only for the _last_ deleted bookmarks right?

Yes, which is like the way GMail works. A single undo system would probably cover most of the pain here and keep complexity down.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Any thoughts on this Madhava?

Comment 7

[Aakash Desai [:aakashd]]

Madhava, ping?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

We can't delete folders anymore