Fix some l10n stuff. Summary Fail. :(

RESOLVED FIXED

Status

addons.mozilla.org Graveyard
Public Pages
RESOLVED FIXED
9 years ago
2 years ago

People

(Reporter: clouserw, Assigned: clouserw)

Tracking

Details

Attachments

(2 attachments)

(Assignee)

Description

9 years ago
Created attachment 364364 [details] [diff] [review]
fix l10n stuff

This has been hanging around in my tree for a bit so I finished it.  I'm filing a bug just to have someone glance over it.  The changes are very minor.  Things it addresses:

1) Most of the English strings that are in _().  I ignored 4 in the dev CP because I don't want to conflict with Jeff's bug.

2) I added comments to all the strings that use %s.  I want us to start doing this from now on (and really, for any string that might be vague) and I figured the best way is to lead by example.

This is only the main files and en-US.  I'll merge to everyone later.
Attachment #364364 - Flags: review?(fwenzel)

Updated

9 years ago
Attachment #364364 - Flags: review?(fwenzel) → review+
Comment on attachment 364364 [details] [diff] [review]
fix l10n stuff

Looks good to me, well done. Note though when you merge this out, the newly added comments will *not* be added to existing strings in the other locales (this only happens when the string to be merged does not exist there yet, in which case the comments will be included). If you find a setting to make the merge process add new comments even to existing tags, please fix our script.
(Assignee)

Comment 2

9 years ago
Created attachment 364396 [details] [diff] [review]
cheesy hack

Thanks, it's committed.

Not pushing comments to the other locales is weak sauce.  After reading a bunch of docs it looks like extracted comments are preserved but translator comments are not.  We're using translator comments right now (which are supposed to be typed by localizers and are represented with "# ") instead of extracted comments (which are supposed to be inserted by developers and are represented with "#.").  I don't think PHP supports extracting comments but we could still use the developer comments.

What do you think of running s/# /#./g on the en-US .po file and then using this patch.  It's pretty cheesy but works in my test.
Attachment #364396 - Flags: review?(fwenzel)
(In reply to comment #2)
> What do you think of running s/# /#./g on the en-US .po file and then using
> this patch.  It's pretty cheesy but works in my test.

Will the existing comments be preserved when we run "extract" on the source code and merge that into the en-US file?
(Assignee)

Comment 4

9 years ago
Existing comments are preserved in my tests but please confirm! :)
Comment on attachment 364396 [details] [diff] [review]
cheesy hack

The whole process is a little brain-twisting but it should work :)
Attachment #364396 - Flags: review?(fwenzel) → review+
(Assignee)

Comment 6

9 years ago
Thanks Fred.  r22764 for the merge script, r22765 for the .po files.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.