480388 - New Account Wizard is shown on every startup although RSS account exists

Status: VERIFIED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090226 Shredder/3.0b3pre (BuildID: 20090226032557)

Steps to Reproduce:
1. Start Thunderbird with new profile
2. In the New Account Wizard select "RSS News & Blogs"
3. Click "Next", confirm name, click "Next", click "Finish"
4. Restart Thunderbird

Actual Results:
New Account Wizard is shown again. Canceling the wizard shows the previously created RSS account in the folder pane.

Expected Results:
New Account Wizard is not shown on every startup.

Issue doesn't exists in Thunderbird 2.0.0.19 (20081209).

Comment 1

[Ludovic Hirlimann [:Usul]]

Confirming on Vista. Nothing in the JS console.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Blocking because this is a regression.  That said, RSS is not a focus of Tb3, and this seems likely to be a _really_ unusual use case, so this is at risk of falling off the bandwagon somewhere down the line.  

It would be interesting to know when this regressed, as that might provide insight into the fix; adding qawanted.

Comment 3

[Stefan Sitter [:ssitter]]

Regression range:

Works in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080818131059 Shredder/3.0b1pre

Fails in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080819031251 Shredder/3.0b1pre

Checkins during regression range:

https://hg.mozilla.org/comm-central/pushloghtml?startdate=2008-08-18+13:10:59&enddate=2008-08-19+03:12:51

https://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?startdate=2008-08-18+13:10:59&enddate=2008-08-19+03:12:51

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Possibly bug 432920?

Comment 5

[Rain [:rain1] (inactive)]

(In reply to comment #4)
> Possibly bug 432920?

Yes, I can see why that would cause this. I haven't stepped through the code, but my guess would be that since the RSS and blogs account is an identity-less account, and I changed the wizardCallback at initial startup from null to non-null, http://mxr.mozilla.org/comm-central/source/mailnews/base/prefs/resources/content/accountUtils.js#155 is true.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Reassigning to sid0 in the hopes that he'll be willing to take a run at this in the Tb3 timeframe.  Sid, if so, please change the state of the bug from NEW to ASSIGNED.  Thanks!

Comment 7

[Rain [:rain1] (inactive)]

I'll take a look at it.

Comment 8

[Rain [:rain1] (inactive)]

Attachment: Add extra parameter to verifyAccounts to differentiate between callers, v1 [Checkin: Comment 12]

So, yes, that was the problem -- here's a patch that adds an extra parameter to verifyAccounts to differentiate between initial startup and compose window.

Comment 9

[Rain [:rain1] (inactive)]

Attachment: Litmus test

Comment 10

[Ludovic Hirlimann [:Usul]]

(In reply to comment #9)
> Created an attachment (id=366885) [details]
> Litmus test

do you plan to enter the litmus testcase in litmus too ?

Comment 11

[Rain [:rain1] (inactive)]

(In reply to comment #10)
> (In reply to comment #9)
> > Created an attachment (id=366885) [details] [details]
> > Litmus test
> 
> do you plan to enter the litmus testcase in litmus too ?

Yes.

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 366881 [details] [diff] [review]
Add extra parameter to verifyAccounts to differentiate between callers, v1
[Checkin: Comment 12]


http://hg.mozilla.org/comm-central/rev/b2c18a94c628

Comment 13

[Rain [:rain1] (inactive)]

Wayne or Ludovic -- can we get this into Litmus?

Comment 14

[Ludovic Hirlimann [:Usul]]

https://litmus.mozilla.org/show_test.cgi?id=7609

Comment 15

[tingmingtian]

This bug will still reproduce on thunderbird 3.0beta2,but has be fixed in thunderbird 3.0beta3