480390 - Include Lightning BuildID in install.rdf for easier QA work

Status: RESOLVED FIXED

(Calendar :: Lightning Only, enhancement)

Description

[Stefan Sitter [:ssitter]]

After removing the BuildID from the Lightning description it is impossible to determine the exact BuildID. But the BuildID is required for some QA work, e.g. finding the correct regression range for a bug.

My suggestion would be to include the BuildID in a comment in the install.rdf file. This way testers can determine the BuildID by just opening the install.rdf file in a text editor.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: [checked in] add BuildID to install.rdf

Reverts the Makefile.in changes from Bug 355927, displays the BuildID like
    <em:version>1.0pre</em:version> <!-- BuildID=20090224155515 -->
in install.rdf.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Can we maybe add the build id in a UI visible field for nightly builds only? Possibly dependant on MOZ_OFFICIAL and hijack <em:contributor> ?

Comment 3

[Stefan Sitter [:ssitter]]

I think MOZILLA_OFFICIAL is always enabled, independent of building a hourly, a nightly or a release build. Maybe someone could add a better solution later but I'd go with the simple solution proposed above.

Comment 4

[Daniel Boelzle [:dbo]]

Maybe we could parse the version and all version strings ending on "pre" will add an em:contributor/em:developer?

Comment 5

[Stefan Sitter [:ssitter]]

Attachment: about dialog proposal

The BuildID should be included for the release builds too. For example if the build server is switched to 'release mode' for several days, or there exists several rc-builds that all have the same final version number. This can be achieved by the simple patch above.

If the BuildID should be displayed in UI it could be done via the about dialog as proposed by Daniel, see attached screenshot.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 364379 [details] [diff] [review]
[checked in] add BuildID to install.rdf

r=philipp

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/b655b829638f>

-> FIXED

Comment 8

[Stefan Sitter [:ssitter]]

How about the proposal from Daniel that is displayed in the screenshot from comment #5? Do we want to display it at all to the user?

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I guess searching for pre would work. I think we should display this information in nightlys, especially for testdays etc.

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Only in nightly builds

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: In all builds

Ah I should read more comments before posting my own. Two patches that do different things, r+ whichever you prefer. I'm indifferent. Remember that release builds are fully localized though,  and the em:developer tag can't be easily localized with the build id, unless maybe we provide the build id also in a .dtd file.

Comment 12

[Daniel Boelzle [:dbo]]

I think having it in "pre" and "rc" builds is sufficient (no need for l10n work).

Comment 13

[Stefan Sitter [:ssitter]]

Comment on attachment 365398 [details] [diff] [review]
Only in nightly builds

I see no sense checking for "rc" in the version number. If it is really a release candidate the version number is identical to the final release, e.g. "1.0". For all non-pre builds the BuildID is still available from the comment in the install.rdf file.

r=ssitter if you change PRE_VERSION to the more verbose LIGHTNING_PRERELEASE_VERSION because the PRE_VERSION define is already used in mozilla code.

Comment 14

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

LIGHTNING_PRERELEASE_VERSION it is.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/4bc7910954ab>

-> FIXED

Comment 15

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".