480443 - URLbar should only show address tooltip when overflowing

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Geoff Lankow (:darktrojan)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2

The tooltip for the location bar is displayed even when the location is clearly visible. It should only show when the location overflows. As far as I can tell, this is the way Firefox used to behave.

Reproducible: Always

Steps to Reproduce:
1. Visit a website with a short address
2. Hover over the location bar
Actual Results:  
Tooltip shows, with the same text as shown in the location bar

Expected Results:  
Tooltip doesn't show, unless address is too long to be displayed

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: patch

This is my first ever patch! Please be gentle. :)

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 364418 [details] [diff] [review]
patch

I didn't know these events work for input fields... nice!

>+            case "overflow":
>+              this._contentIsCropped = true;
>+              break;
>+            case "underflow":
>+              this._contentIsCropped = false;
>+              break;

You need to call this._hideURLTooltip(); in the underflow case, or check self._contentIsCropped in the timeout callback in _initURLTooltip.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: patch v2

Comment 4

[Marco Bonardo [:mak]]

assigning to you for now since you're working on this.

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 364810 [details] [diff] [review]
patch v2

i don't have full browser peer status, and also haven't ever looked at this code. forwarding review request to gavin.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 364810 [details] [diff] [review]
patch v2

This doesn't appear to work (I never get a tooltip with this patch applied). The overflow/underflow events aren't fired for textbox text changes, per https://developer.mozilla.org/En/XUL:Events .

Comment 7

[Geoff Lankow (:darktrojan)]

Overflow/underflow events are fired by the anonymous <div> created in /layout/forms/nsTextControlFrame.cpp, or at least they are on my Windows install and my Linux install.

Comment 8

[Dão Gottwald [:dao]]

WFM on Linux, too.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.

even though the location bar is in the main window, the tooltip should probably be considered secondary UI, and something that is only occasionally relied upon.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 364810 [details] [diff] [review]
patch v2

Hmm, indeed, seems to work fine - not sure what happened when I tested this the first time.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Thanks for the patch, Geoff, and sorry the review took so long :(

Comment 12

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/e3cbcefd4e44