480447 - clear outstanding paint events when repainting the whole canvas

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[(dormant account)]

Attachment: less qi +clear pending events

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 364423 [details] [diff] [review]
less qi +clear pending events

need to clear the cached reference in setCurrentBrowser, since _browser changes then.

typo: redudent

Comment 3

[(dormant account)]

Attachment: fixed

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 364425 [details] [diff] [review]
fixed

>diff --git a/chrome/content/CanvasBrowser.js b/chrome/content/CanvasBrowser.js

>+  get contentDOMWindowUtils() {
>+    if (!this._contentDOMWindowUtils) {

It might be better to add a getter for this on <browser>s, and have it do the caching at some point. Means changing toolkit and another dependency on a recent mozilla-central changeset, though, so I guess we can do this for now. 

>   setCurrentBrowser: function(browser, skipZoom) {
>     let currentBrowser = this._browser;
>     if (currentBrowser) {

>+      this._contentDOMWindowUtils = null;

I think you should clear it each time you set _browser, regardless of whether there was a previous value (i.e. move it outside of the if (currentBrowser) check).

>   elementFromPoint: function(aX, aY) {

>+    let element = this.contentDOMWindowUtils
>+      .elementFromPoint(x, y,
>+                        true,   /* ignore root scroll frame*/
>+                        false); /* don't flush layout */

This indentation is kind of weird, I'd just leave the cwu variable.

r=me with those addressed.

Comment 5

[(dormant account)]

> It might be better to add a getter for this on <browser>s, and have it do the
> caching at some point. Means changing toolkit and another dependency on a
> recent mozilla-central changeset, though, so I guess we can do this for now. 

Yeah I considered that, but making any change to that file is a pain as you described, didn't seem worth it.

pushed http://hg.mozilla.org/mobile-browser/rev/a77e5f6e7ed7